Add: Oura Ring artifact parser#1634
Conversation
Switch all 7 artifact_processor functions from the legacy 5-arg signature to the modern context form (def x(context) + context.get_files_found()), which removes the unused-argument warnings, and mark the defensive broad excepts with an inline pylint disable. Lint 10.00/10; no behavior change.
|
Really nice contribution, @Slay3r00 — thorough coverage across account/identity, Find My Ring GPS, ring/battery status, activity timeline, heart rate, and the Segment analytics, with solid UTC handling and nested bplist/JSON/NSDecimal decoding. 👏 I converted the 7 functions to the modern context form ( A few non-blocking follow-ups for whenever you revisit it:
None of these block the merge. Thanks again for the solid parser! For transparency: the context-form cleanup and this review were done with Claude (Claude Code) at my request. — Brigs |
|
I will add some other notes that are hand-typed. :P you are using module level date conversion functions where we have coverage with api functions in place. we prefer modules do this to have more consistent date handling.
you are also doing manual plist content loading and we have a couple plist api functions that will safely load and decode a lot of the structure including NSKeyed decoding. nice work on the research and code so far! |
|
Thank you both for the feedback! I planned on making a couple more for eventbrite app and dropbox app, and will use the recommended methods provided. |
No description provided.