Tabler icons implementation - CSS update for LEAPPs visual identity#1639
Merged
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pull Bot
pushed a commit
to itsbrex/iLEAPP
that referenced
this pull request
Jul 2, 2026
Now that Tabler icons ship in the report (PR abrignoni#1639), move artifact metadata to native Tabler icon names instead of relying on the feather-to-tabler translation shim, and give every artifact that had no icon a purpose-matched one (they previously fell back to the alert-triangle warning glyph). - 85 artifact_icon values rewritten from feather names to the same Tabler name the shim already resolves them to (pixel-identical rendering), using scripts/data/feather_to_tabler_icon_names.json. - 2 broken values fixed: "credit_card" (underscore typo) never matched any icon and rendered alert-triangle -> "credit-card". - 113 artifacts with no artifact_icon get a purpose-based Tabler icon (e.g. Safari -> compass, Do Not Disturb -> moon, Telegram -> brand-telegram, Bash History -> terminal, Cookies -> cookie). Every assigned name verified to exist in assets/tabler_icons. - ZangiChats: removed stale duplicate "artifact_icon": "" key. Because CI lints every changed file, pre-existing pylint findings in touched files are fixed too (zero-behavior: underscore-prefixed unused args, removed unused imports/variables, inline disables with repo precedent, loop-var inits, for-else de-indent, id -> item_id rename). One real bug fixed in splitwise.py: the notification list built each row with `if '<strong>' and '</strong>' in record[1]` (always-truthy constant) and reused the previous row's `remove_html` when a record had no closing tag, writing the wrong notification text into that row. The strong-tag strip is now applied per record unconditionally. Held back for a follow-up (heavy pre-existing lint debt: mass bad-indentation / undefined-loop-variable): 18 Ph* Photos.sqlite files and BeReal.py keep their feather names (still rendered correctly via the shim) and Ph70's 7 artifacts keep no icon for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.