Migrate last legacy 'chat' data_views to 'conversation'#1644
Merged
Conversation
googleChat and facebookMessenger (both artifacts) were the final modules on
the legacy 'chat' view key / threadDiscriminatorColumn; rename them to the
conversation form so nothing depends on the backward-compatibility shim in
lavafuncs. Column mappings unchanged.
Also clears googleChat's two pre-existing unused-variable warnings ('types'
from the protobuf decode, dead 'media' assignment) so the file lints 10.00.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the final two modules still declaring the legacy
chatdata_view (googleChat.py, and both artifacts infacebookMessenger.py) to the currentconversationform (threadDiscriminatorColumn→conversationDiscriminatorColumn). Column mappings unchanged.With this, every data_view in iLEAPP is on
conversation(verified via PluginLoader dump — 18 artifacts, zerochatremaining), so the backward-compat shim inlavafuncs.py("Remove 'chat' once modules are updated") no longer has in-repo users and can be retired in a future framework pass.Also clears googleChat's two pre-existing unused-variable warnings (whole-file CI lint):
typesfrom the blackboxprotobuf decode →_, and a deadmedia = ''assignment.Testing: pylint
--disable=C,R→ 10.00/10 on both files; byte-compile clean; PluginLoader registers all artifacts with the converted views.