- Fix deprecated header in visual studio version 17.3.0 C++20#1246
Merged
Conversation
derekmauro
requested changes
Aug 10, 2022
Delete deprecated header include
Member
|
Thank you. This will be merged soon. |
snnn
pushed a commit
to microsoft/onnxruntime
that referenced
this pull request
Apr 13, 2023
### Description The following three lines are needed before including some cutlass header files, because cutlass uses "and"/"or" keywords. Generally it should not be a problem without this header, but nvcc is not strictly compliant to C++ standard. ```c++ #ifdef __cplusplus #include <ciso646> #endif ``` We didn't hit this problem because the above code exists in absl. We always include absl headers first. However, ABSL recently deleted them! abseil/abseil-cpp#1246 The cutlass dependency was introduced in #14343 , after we had abseil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a header that was no longer used in c++20 of Visual studio version 17.3.0, so I fixed it.