Skip to content

Compile all dependencies of the DLL with ABSL_CONSUME_DLL #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
copybara-service merged 1 commit into from
Sep 6, 2022
Merged

Compile all dependencies of the DLL with ABSL_CONSUME_DLL #1269

copybara-service merged 1 commit into from
Sep 6, 2022

Conversation

@isuruf
Copy link
Contributor

@isuruf isuruf commented Sep 2, 2022 •
edited
Loading

Fixes #1265
Fixes #1118

@isuruf
Copy link
Contributor Author

isuruf commented Sep 2, 2022

cc @h-vetinari

@h-vetinari h-vetinari mentioned this pull request Sep 2, 2022
Closed
@derekmauro
Copy link
Member

derekmauro commented Sep 2, 2022

@h-vetinari - can you confirm that this fixes your issue?

@isuruf isuruf mentioned this pull request Sep 2, 2022
Open
@h-vetinari h-vetinari mentioned this pull request Sep 3, 2022
Merged
@h-vetinari
Copy link
Contributor

h-vetinari commented Sep 3, 2022

@h-vetinari - can you confirm that this fixes your issue?

I backported the patch to our abseil builds, and indeed RFC_3339_full is now being found in conda-forge/google-cloud-cpp-feedstock#108. 🥳

@copybara-service copybara-service bot merged commit f2b8a81 into abseil:master Sep 6, 2022
@isuruf isuruf deleted the patch-1 branch September 6, 2022 16:57
@derekmauro derekmauro mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing constants causing linking errors in windows builds Missing symbols when using windows shared build

4 participants

@isuruf @derekmauro @h-vetinari @kokoro-team