fix(ci): rename publish.yml to release-please.yml for Trusted Publishing#31
Merged
fix(ci): rename publish.yml to release-please.yml for Trusted Publishing#31
Conversation
npmjs.com Trusted Publishing is configured per workflow file path. The existing config on the @absmartly/cli package points at '.github/workflows/release-please.yml' with job name 'publish' — so renaming the file (contents unchanged) restores OIDC auth without requiring repo-side secrets or a Trusted Publisher reconfiguration on npmjs.com. The internal 'name: Publish' is unchanged. Job name 'publish' is unchanged. Only the file path on disk changed.
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames `.github/workflows/publish.yml` → `.github/workflows/release-please.yml`. Contents unchanged; only the path on disk changes.
Why
npmjs.com Trusted Publishing is bound to a specific workflow file path. The existing Trusted Publisher entry for `@absmartly/cli` points at `.github/workflows/release-please.yml` (job: `publish`, environment: `npm`). When we deleted the original release-please.yml and added a new `publish.yml`, OIDC tokens started getting rejected because the workflow path didn't match — leading to the `ENEEDAUTH` failures we saw on PR #29 and PR #30 attempts.
Renaming the file keeps the new simple version-bump-publish logic but restores OIDC auth without:
The job name (`publish`) and environment (`npm`) are unchanged, so the rest of the Trusted Publisher fingerprint still matches.