Fixing a double free issue with GCC > 9 in optimized mode#56
Closed
mahmoodn wants to merge 3 commits into
Closed
Conversation
Collaborator
|
Hi, Thank you for fixing that. Could you please merge this into dev branch instead of release? Thank you. |
Contributor
Author
|
It seems that current dev version is different from what I modified. I have to check if the problem exists with the new dev version. |
Collaborator
|
This has been merged into dev with #83. Closing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a fix for issues #32 and #49. With GCC > 9 the simulator crashes in trace_driven.cc. The bug can be bypassed with temporarily removing
-O3in trace-driven/Makefile. This function is supposed to return a pointer but it doesn't return anything indeed. Changing that tovoidfixes the runtime crash.Additionally, by looking at
get_next_threadblock_traces()there are unnecessary statements and return types:clear()is redundant because that is done in trace_parser::get_next_threadblock_traces().