Skip to content

Fixing a double free issue with GCC > 9 in optimized mode#56

Closed
mahmoodn wants to merge 3 commits into
accel-sim:releasefrom
mahmoodn:dev
Closed

Fixing a double free issue with GCC > 9 in optimized mode#56
mahmoodn wants to merge 3 commits into
accel-sim:releasefrom
mahmoodn:dev

Conversation

@mahmoodn
Copy link
Copy Markdown
Contributor

@mahmoodn mahmoodn commented Aug 2, 2021

This pull request is a fix for issues #32 and #49. With GCC > 9 the simulator crashes in trace_driven.cc. The bug can be bypassed with temporarily removing -O3 in trace-driven/Makefile. This function is supposed to return a pointer but it doesn't return anything indeed. Changing that to void fixes the runtime crash.

Additionally, by looking at get_next_threadblock_traces() there are unnecessary statements and return types:

@JRPan JRPan self-requested a review February 1, 2022 19:27
@JRPan
Copy link
Copy Markdown
Collaborator

JRPan commented Feb 1, 2022

Hi,

Thank you for fixing that. Could you please merge this into dev branch instead of release? Thank you.

@mahmoodn
Copy link
Copy Markdown
Contributor Author

mahmoodn commented Feb 6, 2022

It seems that current dev version is different from what I modified. I have to check if the problem exists with the new dev version.

@JRPan
Copy link
Copy Markdown
Collaborator

JRPan commented Feb 16, 2022

This has been merged into dev with #83. Closing this

@JRPan JRPan closed this Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants