Issue 133 - #153
Merged
Merged
Conversation
…ck-for-reduced-motion Add reduced-motion fallback for creator skeleton shimmer
…text-for-claims Add standardized claim-action disabled-reason helper text
…t-for-action-sheets Add mobile bottom safe-area inset for dialog action sheets
…ashing Add deterministic fallback avatar colors by creator id
|
@Johnpii1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
merge boss |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add src/utils/avatarColor.util.ts implementing a simple string hash and getFallbackAvatarColors(creatorId) which returns a gradient background and fixed high-contrast text color.
Update CreatorInitialsAvatar to accept an optional creatorId prop and apply the computed fallback gradient and text color when imageSrc is missing or fails to load (src/components/common/CreatorInitialsAvatar.tsx).
Wire creatorId into avatar usages in CreatorCard and CreatorProfileHeader, and update the LandingPage example to pass a creatorId so fallbacks are deterministic (src/components/common/CreatorCard.tsx, src/components/common/CreatorProfileHeader.tsx, src/pages/LandingPage.tsx).
Add unit tests to verify deterministic color generation and that the initials fallback renders with the expected background and text color (src/components/common/tests/CreatorInitialsAvatar.test.tsx).
Testing
Ran lint with pnpm lint and it passed after moving color logic to src/utils/avatarColor.util.ts (✅).⚠️ ).
Ran the new unit tests with pnpm test src/components/common/tests/CreatorInitialsAvatar.test.tsx and both tests passed (✅).
pnpm build was attempted and failed due to an unrelated pre-existing TypeScript error in src/components/ui/dialog.test.tsx (unused React import), which is not part of this change (
pnpm lintpnpm buildChecklist
close #133