fix: resolve issues #633-636 - #637
Merged
Chucks1093 merged 2 commits intoJul 27, 2026
Merged
Conversation
- Issue accesslayerorg#633: Add test for search clear resetting URL and pagination - Issue accesslayerorg#634: Add test for error state component without onRetry - Issue accesslayerorg#635: Add test for sort dropdown initialization from URL param - Issue accesslayerorg#636: Add structured debug log for post-trade cache invalidation Fixes accesslayerorg#633 accesslayerorg#634 accesslayerorg#635 accesslayerorg#636
|
@ritaifeoluwa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Fixes lint error in tradeCacheInvalidation.test.ts
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #633
Closes #634
Closes #635
Closes #636
What changed
Issue #633: Search clear resets URL and pagination
searchfrom URL query string and resets to page oneIssue #634: Error state component without onRetry
CreatorProfileErrorStaterenders without error whenonRetryis not provided and retry button is absentIssue #635: Sort dropdown initialization from URL
?sort=price-ascin URL, verifying dropdown initializes to correct option and initial fetch uses that sortIssue #636: Structured cache invalidation log
[cache-invalidation]log inonSettledofuseTradeMutationwith fields:invalidated_keys,trigger,creator_id,invalidated_at