Skip to content

Add integration test for admin function reverts leaving protocol config values unchanged #651

Description

@Chucks1093

Summary

When an admin function reverts (e.g. due to an unauthorized caller or invalid input), the protocol config values it was attempting to update must remain at their previous values. An integration test should attempt a failing admin call and assert all config values are unchanged after the revert.

Scope

  • Initialize the contract with fee bps 200 and a known fee recipient
  • Attempt to update fee bps to 400 using a non-admin wallet — assert the call reverts
  • Read fee bps and assert it is still 200
  • Attempt to update fee recipient using a non-admin wallet — assert the call reverts
  • Read fee recipient and assert it is still the original address

Acceptance Criteria

  • Fee bps unchanged after failed admin call
  • Fee recipient unchanged after failed admin call
  • Both reads confirm original values post-revert
  • Test uses a wallet that is explicitly not the contract admin

ETA: 12 hours


Coordinate on Telegram

Metadata

Metadata

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions