Add focused zero-balance key read tests#49
Merged
Chucks1093 merged 1 commit intoMar 27, 2026
Merged
Conversation
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds focused tests for zero-balance key read behavior in creator-keys.
Added tests
test_key_balance_zero_for_unregistered_creator_even_when_other_balances_exist
Confirms get_key_balance returns 0 for an unregistered creator, even when other creator/buyer balances exist.
test_key_balance_zero_for_registered_creator_and_unseen_wallet
Confirms get_key_balance returns 0 for a registered creator when the queried wallet has never purchased.
Why
We want explicit coverage of zero-balance read paths so read behavior is clear and stable for indexers/clients:
missing creator + read returns 0
missing creator-wallet balance entry + read returns 0
Scope
Test-only change.
No contract logic changes.
Tests remain small and focused on read behavior.
Validation
Ran local CI-equivalent checks successfully:
make fmt-check
make clippy
make test
All checks passed.
closes #40