Skip to content

test(wallets): add integration tests for holdings 400 on malformed Stellar address (#511) - #519

Merged
Chucks1093 merged 2 commits into
accesslayerorg:mainfrom
KingDavid9999:fixes-issue-#511
Jun 27, 2026
Merged

test(wallets): add integration tests for holdings 400 on malformed Stellar address (#511)#519
Chucks1093 merged 2 commits into
accesslayerorg:mainfrom
KingDavid9999:fixes-issue-#511

Conversation

@KingDavid9999

Copy link
Copy Markdown
Contributor

closes #511

Add integration tests for holdings endpoint malformed address validation (#511)

Adds integration test coverage for GET /wallets/:address/holdings confirming that malformed Stellar addresses are rejected before any database query is attempted.

What's tested

  • Address that is too short returns 400
  • Address with wrong prefix returns 400
  • Address with invalid characters returns 400
  • Error body identifies the address field in all three cases
  • fetchWalletHoldings is not called for any invalid input

Notes

  • No production code changes, validation was already in place via WalletHoldingsParamsSchema and the controller's early return on parse failure
  • Follows the same structure and conventions as wallet-activity.integration.test.ts

@drips-wave

drips-wave Bot commented Jun 26, 2026

Copy link
Copy Markdown

@KingDavid9999 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093
Chucks1093 merged commit b9a7655 into accesslayerorg:main Jun 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add integration test for holdings endpoint returning 400 for malformed Stellar address

2 participants