feat add integration-test - #633
Merged
Merged
Conversation
|
@ONEONUORA Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements four independent improvements across the indexer, webhook, and creator modules.
Changes
1. Indexer — Sell Event Persistence Pipeline
New file:
src/modules/indexer/indexer-pipeline.service.tsImplements a trade event processing pipeline for on-chain
KEY_BOUGHTandKEY_SOLDevents sourced from the Soroban indexer.Features
processTradeEvents(events)— entry point; delegates toprocessIndexerChainEventsfor deduplication and sequential processing.eventType.creatorIdactoramountpricefeePaidtradeAtledgertxHasheventIndexwarnlog.Activityrecord.updateOwnershipwith a signed balance delta.CreatorPriceSnapshot.New file:
src/modules/indexer/indexer-pipeline.integration.test.tsIncludes 3 integration tests covering:
2. Webhooks — Delivery Attempt Logging
Modified:
src/modules/webhooks/webhook.service.tsattemptDeliverynow emits a structuredlogger.infoafter every delivery attempt with:webhook_idevent_typeattempt_numberresponse_status(HTTP status ornullon timeout/error)duration_mssuccessModified:
src/modules/webhooks/webhook.service.test.tsUpdated assertions verify:
callbackUrlis absent from every log entry3. Trading Volume — Rolling Window Boundary Tests
Modified:
src/utils/__tests__/trading-volume.utils.test.tsAdded a Rolling 24-hour Window Boundary Behaviors test suite using fake timers.
gteis inclusive)0nclose #624
close #626
close #627
close #628