fix(csharp): correct Double→double, field array/nullable order, and optional relationship type#228
Merged
jamieshorten merged 1 commit intoMay 22, 2026
Conversation
…ptional relationship type Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
jamieshorten
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Double mapped to
floatinstead ofdouble; Concerto's 64-bit Double was mapped to C#'s 32-bit float. Fixed todouble.writeFieldparameter order (array / nullableType swapped)toCSharpPropertytakes (..., array, nullableType, ...). The call inwriteFieldhad them reversed, causing optional arrays to emitstring?[](array of nullable strings) instead ofstring[]?(optional array).visitRelationshipnever emitted?for optional relationships. TheisOptional()check existed for fields but was missing entirely fromvisitRelationship. Optional relationships always emitted a non-nullable type.Author Checklist
--signoffoption of git commit.mainfromfork:branchname