Skip to content

fix(csharp): correct Double→double, field array/nullable order, and optional relationship type#228

Merged
jamieshorten merged 1 commit into
accordproject:mainfrom
muhabdulkadir:csharp-visitor-fix
May 22, 2026
Merged

fix(csharp): correct Double→double, field array/nullable order, and optional relationship type#228
jamieshorten merged 1 commit into
accordproject:mainfrom
muhabdulkadir:csharp-visitor-fix

Conversation

@muhabdulkadir
Copy link
Copy Markdown
Contributor

@muhabdulkadir muhabdulkadir commented May 21, 2026

Closes #

  • Double mapped to float instead of double; Concerto's 64-bit Double was mapped to C#'s 32-bit float. Fixed to double.

  • writeField parameter order (array / nullableType swapped) toCSharpProperty takes (..., array, nullableType, ...). The call in writeField had them reversed, causing optional arrays to emit string?[] (array of nullable strings) instead of string[]? (optional array).

  • visitRelationship never emitted ? for optional relationships. The isOptional() check existed for fields but was missing entirely from visitRelationship. Optional relationships always emitted a non-nullable type.

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

…ptional relationship type

Signed-off-by: muhammed-abdulkadir <muhammed.abdulkadir@docusign.com>
@jamieshorten jamieshorten merged commit 1c0ce76 into accordproject:main May 22, 2026
11 checks passed
@muhabdulkadir muhabdulkadir deleted the csharp-visitor-fix branch May 22, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants