This repository was archived by the owner on Sep 10, 2022. It is now read-only.
Pass handlers object (self) to createHandler function#333
Closed
chrisui wants to merge 1 commit into
Closed
Conversation
This allows creation and reference of handlers in a single `withHandlers` rather than many.
Contributor
|
Idea super! withHandlers({
a: (props, handlers) => (...args) => handlers.b(props, handlers)(...args),
b: () => (...args) => doStuff(...arg),
})and this is not cool. |
Contributor
Author
|
Totally not tested the code! Just did a quick psuedo diff to demo the idea :) |
Contributor
|
As I said idea super!!! ;-) |
Contributor
|
see #401 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows creation and reference of handlers in a single
withHandlerscall rather than many.Posting this here as a spitball idea. Will wrap up with tests if we think this is a fair addition to recompose!
This avoids the following requirement.
Note: this has definitely popped up as a somewhat edge usage 🤔