Add ImageMap FULL PR4 UI (zones, gizmos, gated preview) - #13
Draft
aceRage wants to merge 1 commit into
Draft
Conversation
Surgical Plater/hooks merge onto Ultra. New gizmo IDs after BrimEars. Keep Ultra paint-depth MMU paths; preview gated on texture data. Co-authored-by: aceRage <aceRage@users.noreply.github.com>
|
❌ Documentation validation failed 🔗 Link Validation Errors📄 doc/developer-reference\Built-in-placeholders-variables.md:
📄 doc/developer-reference\How-to-wiki.md:
📄 doc/Home.md:
📄 doc/Tab.cpp:
🖼️ Image Validation Errors📄 doc/developer-reference\How-to-create-profiles.md:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacks #10 (PR1 libs) + #11 (PR2 hooks) + #12 (PR3 G-code/3MF) + this UI layer.
Feature-patch extract from OrcaSlicer-ImageMap
@92548381056.Ships a usable ImageMap surface on Ultra: create/edit texture-mapping zones in the sidebar, preview, and slice. Surgical Plater + gizmo merge — not a wholesale Plater replace.
C3 is best-effort: no crash; paint-depth clamp holds. Same-object paint-depth + TM is easier with this UI but is not marketing-supported.
See
docs/imagemap-full-pr4.md.How Ultra paint-depth gizmo paths were preserved
GLGizmoMmuSegmentation.cppis unchanged except one additive “Manage Color Data” button after the existing remap UI.GLGizmoTextureMappingTools.cppand renamed:GLGizmoMmuSegmentation→GLGizmoMmuSegmentationImageMap(compiled, not registered)GLMmSegmentationGizmo3DScene→GLMmSegmentationGizmo3DSceneImageMapBrimEarsso Ultra Emboss/Svg/Measure/Assembly/Simplify IDs do not shift.GLGizmoPainterBase::should_render_triangle_texture_preview()defaults to false. Ultra FdmSupports / Seam / FuzzySkin / MMU paint-depth do not enter the TM preview path.slope.actived,slope.volume_world_normal_matrix,slope.normal_z).PaintDepth.*/paint_depth_*/test_paint_depth*.cppare untouched.New gizmo IDs
TrueColorPaintingBrimEarsImageProjectionTextureGradientPointPickeron_is_selectable() == false)Ultra
MmSegmentationremains Color Painting + paint-depth.Preview gating
TriangleSelectorPatch::render_texture_previewreturns immediately unless:m_texture_preview_needed, andm_model_volume != nullptr, andmodel_volume_has_texture_preview_data/ vertex-color / TM color helpers).MMUPaintedTexturePreview.cpp/.hppis additive.Surgical Plater hunks
Helpers live in
TextureMappingPlaterHooks.cpp/.hpp.PartPlate.cppis not edited.get_extruders_colors()+ TM display colors after mixed-filament colorsPlater.cppinit_texture_mapping_panel→TextureMappingSidebarPanel.cppload_filesafterread_from_archiveread_from_filebackground_process.applyupdate_after_undo_redoon_config_changetexture_mapping_zones(not prime-tower images)ArrangeJob.cpponlyForbidden-region grep evidence (this PR4 diff)
No matches.
PartPlate.cpp/SendJob/ Stream / Remote /load_ams_list/get_select_machine_dialog/ phone combo are not in this diff.Tab / object list
texture_mapping_zones.total_filaments.Out of scope
paint_depth_*/PaintDepth.*Screenshots/Recordings/Graphs
Cloud cannot run the wx GUI. No screenshots from this environment.
Tests
test_paint_depth*.cppuntouched (git diffempty).libslic3r_testsor run GUI smoke. Maintainers:[paintdepth],[texturemapping].U1–U4 manual checks (REAPER)
Cloud cannot run GUI smoke. Please run:
texture_mapping_zones, not prime-tower images.texture_mapping_definitions/ global settings persist after save/reopen.paint_depth_*settings remain visible. TrueColor + Image Projection gizmos open from the toolbar.