Skip to content

Conversation

@LinkIsGrim
Copy link
Contributor

@LinkIsGrim LinkIsGrim commented Dec 17, 2024

When merged this pull request will:

  • Title.

New stat isn't completely transparent, but it's less misleading (explosive protection is actually ballistic protection because it's armor, yikes).
image

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@LinkIsGrim LinkIsGrim added the kind/enhancement Release Notes: **IMPROVED:** label Dec 17, 2024
@LinkIsGrim LinkIsGrim changed the title Arsenal - Improve armor stat for medical, fix gforce stat Arsenal - Improve armor stat for medical Dec 26, 2024
@johnb432
Copy link
Contributor

johnb432 commented Jan 4, 2025

V_PlateCarrierGL_blk is reported to be level IV and V_PlateCarrierSpec_blk to be level V.
However

["V_PlateCarrierGL_blk", "HitChest"] call ace_medical_engine_fnc_getItemArmor
returns
[78,20.252]
and
["V_PlateCarrierSpec_blk", "HitChest"] call ace_medical_engine_fnc_getItemArmor
return
[24,19.8021]

Imo that doesn't feel right.

@johnb432
Copy link
Contributor

V_PlateCarrierGL_blk is reported to be level IV and V_PlateCarrierSpec_blk to be level V. However

["V_PlateCarrierGL_blk", "HitChest"] call ace_medical_engine_fnc_getItemArmor returns [78,20.252] and ["V_PlateCarrierSpec_blk", "HitChest"] call ace_medical_engine_fnc_getItemArmor return [24,19.8021]

Imo that doesn't feel right.

Might need to do an average for the chest of multiple hitpoints to get a better estimate of armor level.

@Drofseh
Copy link
Contributor

Drofseh commented Jun 29, 2025

I think I'd prefer just showing the actual config values of the armour rather than trying to convert it to to an approximate of a real world standard.

Being able to see that vest A has 45 armour and vest B has 65 is a much easier comparison and makes it more transparent as to why mixing and matching armour and ammo from different mods might not work as expected.

@LinkIsGrim
Copy link
Contributor Author

Problem I have with that is "45 armor" doesn't indicate much if you don't know how damage works (even if higher is better).

Do stats have tooltip support? I'd be okay with showing raw values when hovering over the bar

Co-authored-by: johnb432 <58661205+johnb432@users.noreply.github.com>
@LinkIsGrim
Copy link
Contributor Author

Do stats have tooltip support?

No. Might be doable?

@Drofseh
Copy link
Contributor

Drofseh commented Jun 29, 2025

Do stats have tooltip support?

No. Might be doable?

Yeah a tooltip would be ok if it's possible.

@Drofseh
Copy link
Contributor

Drofseh commented Jun 29, 2025

Problem I have with that is "45 armor" doesn't indicate much if you don't know how damage works (even if higher is better).

Level X armour will have the exact same problem though, and i think it will be more confusing since the real world level implies a specific in game behavior.

"Bug - ModA 7.62 goes though ModB's Level 3 vest but not ModC's Level 3 vest"

Giving the specific numerical value as a unit-less number much not mean much for any one armour, but is easier to compare when looking at different vests, especially if we're crushing the armour down to only ~5 levels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants