Skip to content

Interact Menu - Fix _actionParams not accessible in action condition#11385

Merged
PabstMirror merged 2 commits into
acemod:masterfrom
Dystopian:fix_no__actionParams
May 30, 2026
Merged

Interact Menu - Fix _actionParams not accessible in action condition#11385
PabstMirror merged 2 commits into
acemod:masterfrom
Dystopian:fix_no__actionParams

Conversation

@Dystopian
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • title.

While here, do we need to protect _actionParams? ATM it can be changed in condition/statement/insertChildren code if it is an array or a hashmap.
Can add something like this

if (typeName _actionParams in ["ARRAY", "HASHMAP"]) then {
    _actionParams = +_actionParams;
};

@PabstMirror PabstMirror added this to the 3.21.1 milestone May 20, 2026
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label May 20, 2026
@PabstMirror
Copy link
Copy Markdown
Contributor

ref original #10527
There may be valid use cases to modify array in statement/condition so I don't think we need to protect

@johnb432 johnb432 changed the title Interact Menu - Fix _actionParams not accessible in action condition Interact Menu - Fix _actionParams not accessible in action condition May 28, 2026
@PabstMirror PabstMirror merged commit c20e2a8 into acemod:master May 30, 2026
3 checks passed
@Dystopian Dystopian deleted the fix_no__actionParams branch June 3, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug-fix Release Notes: **FIXED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants