Unique maps for markers#3601
Conversation
|
Thank you for making the PR @SzwedzikPL. I'll review and provide feedback soon. |
|
You have a finite map ids but never release any. This results in a growing registery of ids and the risk of long sessions running out of map ids. |
|
New map is generated only if not unique map is taken by player. |
@SzwedzikPL, I think @Glowbal is refering to public servers, in which you may have a large number of players connecting and disconnecting between server restarts. In that case, you may very well run out of map ids. To be honest, I don't see any good way to if a given map will no longer be needed and releasing it's id. Maybe the best solution would be that if you need a new unique map and there's no more left, just reset and use the oldest one that was abandoned. Or something along those lines. |
|
I think public servers should just disable this option. I don't see any benefits of this solution on public server. We can make unique maps disabled by default to make this easier for them. |
| PREP(sendMarkersJIP); | ||
| PREP(setMarkerJIP); | ||
| PREP(setMarkerNetwork); | ||
| PREP(initInsertMarker); |
There was a problem hiding this comment.
functions should be in alphabetical order
|
|
||
| params ["_item"]; | ||
|
|
||
| _item == "ItemMap" || _item call FUNC(isUniqueMap) |
There was a problem hiding this comment.
This whole function could be replaced with isKindOf.
|
I've added note about polyline markers |
|
Would this work by making maps magazines? That way you have unique items and don't risk running out of IDs. |
Is this possible to make magazine a usable map? (i mean map that you can put on map slot in inventory) |
|
I am not sure, but you could do something similar to ACRE2. Hide the inventory UI for map and track that in the background on inventory change events maybe. |
|
TBH @jonpas, I much rather keep the current methodology. It's much simpler, On Wed, Jun 8, 2016 at 10:10 PM, jonpas notifications@github.com wrote:
|
| @@ -1,20 +1,59 @@ | |||
| // by commy2 | |||
|
@SzwedzikPL Status on this one? |
|
Map drawing still has absolutely no script support. |
|
I'll close this. 4 years and no updates. |
|
Hold my beer |
8 participants
When merged this pull request will:
Demo: https://www.youtube.com/watch?v=fV-k580Ld2A
Todo
The polyline markers for now are quite impossible to handle by scripts. There's no way to add polyline marker. It's needed becouse we need to delete and add markers based on what map you have. I hope BI will add tools (proper script support) to allow us to do this.