Skip to content

Improve creation time of house actions dummy#4159

Merged
PabstMirror merged 1 commit intomasterfrom
improveHouseActions
Jul 26, 2016
Merged

Improve creation time of house actions dummy#4159
PabstMirror merged 1 commit intomasterfrom
improveHouseActions

Conversation

@PabstMirror
Copy link
Copy Markdown
Contributor

  • impmrove speed of creating actions for buildings

On mission from jonpas with lots of wall objects inside of a warehouse, there was a huge stutter when creating actions (the building had ~8 doors + 2 ladders).

This PR improves the time from 137.893 ms -> 1.17631 ms

Thanks to @esteldunedain for the idea from the casing PR.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Jul 24, 2016
@PabstMirror PabstMirror added this to the 3.7.0 milestone Jul 24, 2016
{
private _helperPos = AGLtoASL (_houseBeingScaned modelToWorld (_houseBeingScaned selectionPosition _x));
private _helperObject = "ACE_LogicDummy" createVehicleLocal _helperPos;
private _helperObject = "ACE_LogicDummy" createVehicleLocal [0,0,0];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment so someone doesn't change it back while doing something else.

@PabstMirror PabstMirror merged commit fa7d0df into master Jul 26, 2016
@PabstMirror PabstMirror deleted the improveHouseActions branch July 26, 2016 05:03
@commy2
Copy link
Copy Markdown
Contributor

commy2 commented Jul 26, 2016

Thumbs up and shame @ BI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants