Music compatibility #5320
Closed
fishykins wants to merge 2 commits into
Closed
Conversation
Contributor
|
Maybe you can add it as an ace setting so everyone can set whatever they want instead of what mission maker set. |
thojkooi
requested changes
Jul 9, 2017
Contributor
There was a problem hiding this comment.
This should make use of the ACE settings framework, rather than defining an own global variable.
Here is the documentation on it: https://ace3mod.com/wiki/framework/settings-framework.html
An example would be to add the following to the ACE_Settings.hpp file:
class GVAR(setMusicVolume) {
value = 1;
typeName = "BOOL";
isClientSettable = 0;
};
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small change that adds the option to stop music volume being set. If "ace_setMusicVolume" is false, music volume will not be set. Default value is true, so base functionality is unchanged.