Skip to content

Music compatibility #5320

Closed
fishykins wants to merge 2 commits into
acemod:masterfrom
fishykins:master
Closed

Music compatibility #5320
fishykins wants to merge 2 commits into
acemod:masterfrom
fishykins:master

Conversation

@fishykins
Copy link
Copy Markdown
Contributor

This is a small change that adds the option to stop music volume being set. If "ace_setMusicVolume" is false, music volume will not be set. Default value is true, so base functionality is unchanged.

@rebelvg
Copy link
Copy Markdown
Contributor

rebelvg commented Jul 9, 2017

Maybe you can add it as an ace setting so everyone can set whatever they want instead of what mission maker set.

Copy link
Copy Markdown
Contributor

@thojkooi thojkooi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should make use of the ACE settings framework, rather than defining an own global variable.

Here is the documentation on it: https://ace3mod.com/wiki/framework/settings-framework.html

An example would be to add the following to the ACE_Settings.hpp file:

class GVAR(setMusicVolume) {
    value = 1;
    typeName = "BOOL";
    isClientSettable = 0;
};

@thojkooi thojkooi added kind/enhancement Release Notes: **IMPROVED:** status/WIP labels Jul 9, 2017
@commy2 commy2 self-assigned this Dec 31, 2017
@commy2 commy2 closed this in #6001 Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:** status/WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants