Skip to content

Remove PhysX from ugl smoke grenades#7244

Closed
commy2 wants to merge 2 commits into
masterfrom
uglSmokeBounce
Closed

Remove PhysX from ugl smoke grenades#7244
commy2 wants to merge 2 commits into
masterfrom
uglSmokeBounce

Conversation

@commy2
Copy link
Copy Markdown
Contributor

@commy2 commy2 commented Oct 20, 2019

When merged this pull request will:
With default values, the only (apparent) differences between shotSmokeX and shotDeploy are:

  • no smoke creation
  • no smoke sound
  • old physics with configurable bounce (deflectionSlowDown etc.)

shotSmoke has smoke creation, but no smoke sounds, which is why #4648 was rejected.

Best way to achieve old physcis, but with smoke sound was to attach a shotSmokeX to a shotShell/shotSmoke/shotDeploy. Of these shotDeploy is the only one that has no side effects (explosion of shotShell, [duplicate] smoke creation of shotSmoke) with default values.
There don't seem to be duplicated bounce sound effects, likely because (most) physics are disabled for attached objects.

Both, the "physics projectile" (shotDeploy) and the "smoke projectile" (shotSmokeX) are deleted after timeToLive.

@commy2 commy2 added the kind/enhancement Release Notes: **IMPROVED:** label Oct 20, 2019
@commy2 commy2 added this to the 3.13.0 milestone Oct 20, 2019
jonpas
jonpas previously approved these changes Oct 20, 2019
Copy link
Copy Markdown
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just... why does it work like this!? But nice find and fix!

@PabstMirror
Copy link
Copy Markdown
Contributor

Doesn't work in mp, probably can't attach to simulation type
test

@commy2
Copy link
Copy Markdown
Contributor Author

commy2 commented Oct 20, 2019

It may be that every client has their own projectile, so it needs createVehicleLocal and global execution. I will change it, can you retry then @PabstMirror ?

@PabstMirror
Copy link
Copy Markdown
Contributor

floating in mid air
test2

also, I think i heard multiple "grenade pin" effects from shooters location, not positive (cvl might not be local)

@commy2 commy2 dismissed jonpas’s stale review October 20, 2019 17:34

doesn't work

@jonpas jonpas modified the milestones: 3.13.0, 3.14.0 Dec 7, 2019
@PabstMirror PabstMirror modified the milestones: 3.15.1, Ongoing May 24, 2022
@jonpas jonpas closed this Sep 11, 2023
@jonpas jonpas deleted the uglSmokeBounce branch September 11, 2023 00:55
@jonpas
Copy link
Copy Markdown
Member

jonpas commented Sep 11, 2023

We could provide an optional for this. We use @BaerMitUmlaut's version: https://github.com/Theseus-Aegis/Mods/blob/5ce562312c08d9a6d01e046886c29d09f874c991/addons/ballistics/CfgAmmo.hpp

But it's also so simple that any group that would use it probably has their own version of it already.

@rautamiekka
Copy link
Copy Markdown
Contributor

We could provide an optional for this. We use @BaerMitUmlaut's version: https://github.com/Theseus-Aegis/Mods/blob/5ce562312c08d9a6d01e046886c29d09f874c991/addons/ballistics/CfgAmmo.hpp

But it's also so simple that any group that would use it probably has their own version of it already.

Accessibility is more important than how simple it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement Release Notes: **IMPROVED:** status/WIP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants