Skip to content

Conversation

@driusan
Copy link
Collaborator

@driusan driusan commented Oct 21, 2025

This translates the recruitment widget (the last widget) on the LORIS dashboard, so that the entire dashboard is now translated (The recruitment widget had been waiting on #9937 to be merged before translating it.). Japanese is used as a test language.

It also fixes a regression on the study progression translation introduced by #9937 as new filters that are shared between the two were added.

@driusan driusan added the Multilingual Any tasks related to making LORIS multilingual label Oct 21, 2025
@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Language: Javascript PR or issue that update Javascript code Module: statistics PR or issue related to statistics module labels Oct 21, 2025
@racostas racostas self-requested a review October 21, 2025 19:46
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some translations that don't seems to load in my side:

image image image image

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 21, 2025
@driusan
Copy link
Collaborator Author

driusan commented Oct 21, 2025

I am not sure where "Pie" and "Bar" come from. They do not seem to be in the code. @skarya22 do you know?

"Participants: xxx" and "Overall Recruitment" should be translated, though. I'll try and look into them and "Unknown". Do we translate the "Loading..." elsewhere in LORIS?

@racostas
Copy link
Contributor

I am not sure where "Pie" and "Bar" come from. They do not seem to be in the code. @skarya22 do you know?

"Participants: xxx" and "Overall Recruitment" should be translated, though. I'll try and look into them and "Unknown". Do we translate the "Loading..." elsewhere in LORIS?

  • Yes Pie and Bar seems to came from the library used but myself I'm don' t know.
  • I did saw the translations for "Overall Recruitment" in the code but somehow they are not loading for me. If you can retest in your side would be great.
  • Regarding "Loading...", I don't think we translated this before... maybe is not super evident in other parts and was evident here because is taking more time... just saying… not sure if we can implement it easily... we can put an image "like a sandglass" or something and we avoid translations.

@driusan
Copy link
Collaborator Author

driusan commented Oct 22, 2025

@racostas I added translations for the missing line graph labels, "Unknown" and "Loading...". I don't think I can do Pie/Bar since it doesn't seem to be coming from our code.

I'm not sure why "Overall Recruitment" isn't translating for you, it is for me. Did you restart the web server after running make dev or make locales to be sure it's not using a cache?

Can you re-test?

@driusan driusan removed the State: Needs work PR awaiting additional work by the author to proceed label Oct 22, 2025
@github-actions github-actions bot added the Module: dashboard PR or issue related to dashboard module label Oct 22, 2025
@driusan driusan force-pushed the RecruitmentDashboardJA branch from c427d32 to e9c3943 Compare October 22, 2025 14:52
@racostas racostas self-requested a review October 22, 2025 20:06
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now !

image image image image

@racostas racostas added the Passed manual tests PR has been successfully tested by at least one peer label Oct 22, 2025
@driusan driusan merged commit 00ee1f9 into aces:main Oct 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: Javascript PR or issue that update Javascript code Language: PHP PR or issue that update PHP code Module: dashboard PR or issue related to dashboard module Module: statistics PR or issue related to statistics module Multilingual Any tasks related to making LORIS multilingual Passed manual tests PR has been successfully tested by at least one peer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants