-
Notifications
You must be signed in to change notification settings - Fork 188
[dashboard/statistics] Translate Recruitment widget #10059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
racostas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I am not sure where "Pie" and "Bar" come from. They do not seem to be in the code. @skarya22 do you know? "Participants: xxx" and "Overall Recruitment" should be translated, though. I'll try and look into them and "Unknown". Do we translate the "Loading..." elsewhere in LORIS? |
|
|
@racostas I added translations for the missing line graph labels, "Unknown" and "Loading...". I don't think I can do Pie/Bar since it doesn't seem to be coming from our code. I'm not sure why "Overall Recruitment" isn't translating for you, it is for me. Did you restart the web server after running Can you re-test? |
c427d32 to
e9c3943
Compare
racostas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.








This translates the recruitment widget (the last widget) on the LORIS dashboard, so that the entire dashboard is now translated (The recruitment widget had been waiting on #9937 to be merged before translating it.). Japanese is used as a test language.
It also fixes a regression on the study progression translation introduced by #9937 as new filters that are shared between the two were added.