refactor: remove submit_subtasks_from_json#1479
Conversation
Signed-off-by: freedisch <freeproduc@gmail.com>
prioux
left a comment
prioux
left a comment
There was a problem hiding this comment.
Thanks for your contribution. THere are just a few more minor adjustments to the code I'd like made, see my comments (basically, more lines to remove). Once this is done I'll merge the PR.
| if task.class.properties[:can_submit_new_tasks].present? | ||
| task.submit_subtasks_from_json | ||
| end | ||
|
|
There was a problem hiding this comment.
The comment block at lines 286-288 is an explanation for the lines you removed, so these comments should also be removed. Leave a single blank line before the final return please.
| @@ -2611,147 +2611,8 @@ def install_ext3fs_filesystem(filename,size) #:nodoc: | |||
|
|
|||
| public | |||
There was a problem hiding this comment.
The public keyword here affects all declarations the follows in the file. In this case, it affected the method you deleted. Just after that is the keyword protected which affects the other method you deleted. And after that follows code for "Singularity Load" which stays the same and has its own private keyword. Therefore, I think you should also remove the public and private which are now useless.
|
Note to myself: after merge, clean up a few remaining connections with the new integrator, e.g. the class 'properties' of the task in BourreauClusterTask. Leave the old integrator alone, it's deprecated. |
Signed-off-by: freedisch <freeproduc@gmail.com>
|
Thanks. As soon as the tests finish I'll squash-merge. |
2 participants
Solved issue #1470
The following methods should be removed entirely from the ClusterTask class:
and submit_subtasks_from_json call in the
bourreau_worker