chore(release): release v1.0.0-rc2 - #119
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe release candidate advances from rc1 to rc2 across project metadata and release documentation. Coverage generation is consolidated into a strict LCOV pipeline used locally and in CI. Changelog generation now ignores conflicting tags pointing at HEAD. ChangesRelease and coverage updates
Estimated code review effort: 4 (Complex) | ~45 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/RELEASING.md`:
- Around line 208-217: Update both Zenodo hook lookups in the release
instructions to include --paginate so all pages are queried. Add --slurp
specifically to the ZENODO_HOOK_COUNT query so its jq filter processes the
combined paginated results, while preserving the existing matching criteria and
hook-ID lookup behavior.
- Around line 247-258: Update the Zenodo delivery check using ZENODO_HOOK_ID so
it selects the delivery associated with the current $TAG rather than the first
release event, then explicitly validate status == "success" and status_code ==
200. Make the release process fail when no matching successful delivery is found
or either status check fails.
In `@scripts/tests/test_generate_changelog.py`:
- Around line 111-114: The git mock fixture in the changelog generation test
must include the requested v1.0.0-rc2 tag in the HEAD-tag query output. Update
the second subprocess.CompletedProcess in the git.side_effect sequence while
preserving the existing tag-history fixture and assertions, so
head_tag_ignore_pattern() is exercised against that requested tag.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: f88222c0-39cc-4b2a-8fe4-4b13a246ba14
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (18)
.codecov.yml.github/CONTRIBUTING.md.github/workflows/codecov-upload.ymlCHANGELOG.mdCITATION.cffCMakeLists.txtJustfileREADME.mdREFERENCES.mddocs/Doxyfiledocs/RELEASING.mdpyproject.tomlscripts/codecov.shscripts/coverage.shscripts/gcov.shscripts/generate_changelog.pyscripts/tests/test_generate_changelog.pyvcpkg.json
💤 Files with no reviewable changes (3)
- scripts/gcov.sh
- scripts/codecov.sh
- .codecov.yml
Query all webhook pages and select the delivery matching the release tag. Fail verification when the matching delivery is absent or unsuccessful.
Summary by CodeRabbit
just coverage).