Skip to content

fix(core): add FORWARD/BACKWARD to Direction enum (matches _row_to_synapse default) - #24

Merged
acidkill merged 1 commit into
acidkill:mainfrom
RobertSigmundsson:fix/direction-enum-forward-backward
Jun 22, 2026
Merged

fix(core): add FORWARD/BACKWARD to Direction enum (matches _row_to_synapse default)#24
acidkill merged 1 commit into
acidkill:mainfrom
RobertSigmundsson:fix/direction-enum-forward-backward

Conversation

@RobertSigmundsson

Copy link
Copy Markdown
Contributor

Summary

_row_to_synapse defaults direction='forward', but 'forward'/'backward' are not members of the Direction enum (uni/bi). Reading any synapse that hits the default path is a latent ValueError.

Changes

  • core/synapse.py: add FORWARD = "forward" and BACKWARD = "backward" to Direction.

Type of Change

  • Bug fix (non-breaking)

CHANGELOG (### Fixed)

  • Add FORWARD/BACKWARD to the Direction enum so the existing 'forward' default in _row_to_synapse is valid (was a latent ValueError).

Context: #15

…napse default)

Co-Authored-By: Captain Nemo <noreply@anthropic.com>
@acidkill
acidkill merged commit 41d8075 into acidkill:main Jun 22, 2026
acidkill pushed a commit that referenced this pull request Jun 22, 2026
* fix: resolve issues #19, #20, #21

#19 - OpenClaw plugin execute() signature:
  All 6 tool execute callbacks used (args) instead of (_id, args).
  OpenClaw passes (tool_use_id, params) — first arg was the ID string,
  not actual arguments. Fixed all callbacks in tools.ts.

#20 - Auto-consolidation "none" strategy crash:
  _select_strategies() collected recommended_strategy="none" from the
  "memories expiring soon" hint, causing ValueError when cast to
  ConsolidationStrategy enum. Filter "none" from results.

#21 - nmem remember --stdin flag:
  Add --stdin option to read content from stdin, avoiding shell escaping
  issues with backticks, dollar signs, and quotes in hook scripts.

Closes #19, closes #20, closes #21

* style: format memory.py to pass ruff format check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants