Spine split increment 5: extract main-skill-mods phase (resolves the God-Object)#13
Merged
Conversation
… (1b/1b-ii/1c) Fifth spine-split increment: extract the main-skill injection phase (skill base mods / quality / unselected-set / DoT flags / corpse explosion / crossbow reload / support / trigger + skill damage-multiplier MORE + weapon base crit) into inject_main_skill_mods, taking the derived main_skill tuple + weapon + dmg_mult by explicit params. This is the last injection phase tightly coupled to the derivation locals. The spine is now a derivation section (303-585, computing the inputs) followed by a clean sequence of inject_* calls + perform — the God-Object is resolved. 12 injection phases extracted across PR #8/#9/#10/#12 + this. Verified: cargo nextest run --workspace = 2092 passed/0 failed; fmt + clippy clean; parity zero-drift (def25 84.2 / defcore 91.7 / off 77.5 / dot 59.5 @5%).
ackness
added a commit
that referenced
this pull request
Jul 18, 2026
- def 25-col: 431 -> 437 @5%, 439 -> 445 @10% (six wolf-pack cells: 5x MaxHit + TotalEHP). off/dot/core-8 unchanged. - docs/adapting-to-0.5.4b.md: #13 section - three root causes (enemy Intimidated base pair, The Adorned corrupted-magic-jewel scaling, Runeforged base-armour display-line lag) with oracle evidence and vendor line refs; oracle tooling notes.
ackness
added a commit
that referenced
this pull request
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth and effectively final spine-split increment. Extracts the main-skill injection phase (skill base mods / quality / unselected-set / DoT flags / corpse explosion / crossbow reload / support / trigger + skill damage-multiplier MORE + weapon base crit) into
inject_main_skill_mods, taking the derivedmain_skilltuple +weapon+dmg_multby explicit params.This was the last injection phase tightly coupled to the derivation locals. The spine is now a derivation section (303-585, computing the inputs) followed by a clean sequence of
inject_*calls +perform— the 994-line God-Object is resolved. 12 injection phases extracted across PR #8/#9/#10/#12 + this.Verification
cargo nextest run --workspace— 2092 passed / 0 failedcargo fmt --check+cargo clippy -p pobr-build --all-targets -- -D warnings— clean