Skip to content

Conversation

@devksingh4
Copy link
Member

@devksingh4 devksingh4 commented Oct 31, 2025

Summary by CodeRabbit

  • Chores
    • Updated external shortlinks across the application to new unified domains. Affected links include Discord invitations, reimbursement submissions, SIG pizza signups, and member access request support pages.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 31, 2025

Walkthrough

External links across API and UI components are updated from go.acm.illinois.edu domain to acm.gg domain. Three files contain URL replacements for Discord, reimbursement, sign pizza, and access request links. No logic or control flow modifications.

Changes

Cohort / File(s) Summary
External link domain migration
src/api/functions/ses.ts, src/ui/components/AppShell/index.tsx, src/ui/components/AuthGuard/index.tsx
Updated external links from https://go.acm.illinois.edu/[path] to https://acm.gg/[path] format. Affected links: Discord, reimbursement, sign pizza, and access request endpoints.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Homogeneous changes across files (simple URL string replacements)
  • No functional logic, error handling, or API signature modifications
  • Straightforward find-and-replace pattern with consistent substitution

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Update links to be acm.gg instead of go.acm" accurately describes the primary change across all three modified files: ses.ts, AppShell/index.tsx, and AuthGuard/index.tsx. The changes consistently replace old URLs using the go.acm.illinois.edu domain with new URLs using the acm.gg domain, which is precisely what the title conveys. The title is clear, specific, and concise, allowing a teammate scanning the repository history to immediately understand the purpose of the changeset without ambiguity or vagueness.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch dsingh14/update-links

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

💰 Infracost report

Monthly estimate generated

This comment will be updated when code changes.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 79bc1fd and 356f727.

📒 Files selected for processing (3)
  • src/api/functions/ses.ts (1 hunks)
  • src/ui/components/AppShell/index.tsx (1 hunks)
  • src/ui/components/AuthGuard/index.tsx (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build Application
  • GitHub Check: Run Unit Tests
🔇 Additional comments (2)
src/ui/components/AuthGuard/index.tsx (1)

214-215: LGTM! Access request link properly updated.

The access request form link has been correctly migrated to the new acm.gg domain and is now rendered inline within the message.

src/ui/components/AppShell/index.tsx (1)

124-124: LGTM! External navigation links properly updated.

Both the reimbursement request and pizza request form links have been correctly migrated to the new acm.gg domain.

Also applies to: 130-130

</p>
<div style="text-align: center; margin-top: 20px;">
<a href="https://go.acm.illinois.edu/discord" class="button">Join our Discord</a>
<a href="https://acm.gg/discord" class="button">Join our Discord</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

LGTM! Domain migration looks correct.

The Discord link has been properly updated to the new acm.gg domain.

Verify that the new URL is accessible and redirects correctly:


🏁 Script executed:

#!/bin/bash
# Description: Verify the new Discord link is accessible and check for any other instances of the old domain

# Check if the new URL is accessible
echo "Testing new Discord URL..."
curl -I -L -s -o /dev/null -w "%{http_code}" https://acm.gg/discord

# Search for any remaining instances of the old domain in the codebase
echo -e "\nSearching for remaining instances of go.acm.illinois.edu..."
rg -n "go\.acm\.illinois\.edu" --type-add 'web:*.{ts,tsx,js,jsx,html}' --type web

Length of output: 180


Update test file to reflect domain migration.

The new Discord URL is accessible (HTTP 200), but the domain migration is incomplete. The test file still references the old domain:

  • git/tests/unit/organizations.test.ts:55: Update "https://go.acm.illinois.edu/discord" to "https://acm.gg/discord"
🤖 Prompt for AI Agents
In src/api/functions/ses.ts around line 229 the HTML anchor uses the new Discord
URL but the unit test git/tests/unit/organizations.test.ts (line ~55) still
expects "https://go.acm.illinois.edu/discord"; update that test expectation to
"https://acm.gg/discord" (or adjust the fixture string) so the test matches the
migrated domain; run the unit tests to verify and commit the updated test file.

@devksingh4 devksingh4 merged commit 48a66e8 into main Oct 31, 2025
12 of 13 checks passed
@devksingh4 devksingh4 deleted the dsingh14/update-links branch October 31, 2025 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants