Skip to content

Update links to be acm.gg instead of go.acm #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2025
Merged

Update links to be acm.gg instead of go.acm #365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/api/functions/ses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ export function generateSalesEmail(
If you have any questions, feel free to ask on our Discord!
</p>
<div style="text-align: center; margin-top: 20px;">
<a href="https://go.acm.illinois.edu/discord" class="button">Join our Discord</a>
<a href="https://acm.gg/discord" class="button">Join our Discord</a>
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

LGTM! Domain migration looks correct.

The Discord link has been properly updated to the new acm.gg domain.

Verify that the new URL is accessible and redirects correctly:

🏁 Script executed:

#!/bin/bash
# Description: Verify the new Discord link is accessible and check for any other instances of the old domain

# Check if the new URL is accessible
echo "Testing new Discord URL..."
curl -I -L -s -o /dev/null -w "%{http_code}" https://acm.gg/discord

# Search for any remaining instances of the old domain in the codebase
echo -e "\nSearching for remaining instances of go.acm.illinois.edu..."
rg -n "go\.acm\.illinois\.edu" --type-add 'web:*.{ts,tsx,js,jsx,html}' --type web

Length of output: 180

Update test file to reflect domain migration.

The new Discord URL is accessible (HTTP 200), but the domain migration is incomplete. The test file still references the old domain:

  • git/tests/unit/organizations.test.ts:55: Update "https://go.acm.illinois.edu/discord" to "https://acm.gg/discord"
🤖 Prompt for AI Agents 
In src/api/functions/ses.ts around line 229 the HTML anchor uses the new Discord
URL but the unit test git/tests/unit/organizations.test.ts (line ~55) still
expects "https://go.acm.illinois.edu/discord"; update that test expectation to
"https://acm.gg/discord" (or adjust the fixture string) so the test matches the
migrated domain; run the unit tests to verify and commit the updated test file.

</div>
</div>
<div class="footer">
Expand Down
4 changes: 2 additions & 2 deletions src/ui/components/AppShell/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,13 +121,13 @@ export const navItems = [

export const extLinks = [
{
link: "https://go.acm.illinois.edu/reimburse",
link: "https://acm.gg/reimburse",
name: "Funding and Reimbursement Requests",
icon: IconFileDollar,
description: null,
},
{
link: "https://go.acm.illinois.edu/sigpizza",
link: "https://acm.gg/sigpizza",
name: "Pizza Request Form",
icon: IconPizza,
description: null,
Expand Down
6 changes: 2 additions & 4 deletions src/ui/components/AuthGuard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,10 +211,8 @@ export const AuthGuard: React.FC<
<Title>Unauthorized</Title>
<Text>
You have not been granted access to this module. Please fill out the{" "}
<a href="https://go.acm.illinois.edu/access_request">
access request form
</a>{" "}
to request access to this module.
<a href="https://acm.gg/access_request">access request form</a> to
request access to this module.
</Text>
<Card withBorder>
<Title order={3} mb="md">
Expand Down
Loading