Skip to content

Conversation

@watason
Copy link
Contributor

@watason watason commented Aug 26, 2022

Share updated to generic type

types are bool,int,float,double,other(string).

@watason watason linked an issue Aug 26, 2022 that may be closed by this pull request
@watason watason requested review from arukuka and mdonaka August 26, 2022 03:26
@watason watason closed this Aug 26, 2022
@watason watason deleted the feature/ichikawa/sint branch August 26, 2022 03:45
@watason watason reopened this Aug 26, 2022
@watason watason force-pushed the feature/ichikawa/sint branch from e64d5bd to c44ea6e Compare August 26, 2022 04:44
@come2ry
Copy link
Contributor

come2ry commented Sep 1, 2022

LGTM

@arukuka
Copy link
Member

arukuka commented Sep 1, 2022

@watason Thank you for your contribution!
Same as #23 (review), could you change the author/committer of commit if you don't mind?

Thank you for your contribution! LGTM.

This is a quite minute thing, but there is a notational variation in the author of the commit.
Could you correct it if you don't mind?
Also, please register email address used to GitHub for showing icon. 🙇

@watason watason force-pushed the feature/ichikawa/sint branch from 14a0cf5 to 0f62fc4 Compare September 1, 2022 04:08
@arukuka
Copy link
Member

arukuka commented Sep 1, 2022

@watason
Thank you for your quick response!
I will merge it.

@arukuka arukuka merged commit 5ad6b4f into develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create generic share class

5 participants