Skip to content

Conversation

@watason
Copy link
Contributor

@watason watason commented Aug 26, 2022

Summary

implimentation nesterov momentum

Purpose

Contents

Testing Methods Performed

@watason watason requested review from arukuka and mdonaka August 26, 2022 04:03
@come2ry
Copy link
Contributor

come2ry commented Aug 26, 2022

@watason
Up to how many input sizes is this optimization function guaranteed to work?

@watason
Copy link
Contributor Author

watason commented Aug 31, 2022

@come2ry
i'm not sure what you are talking about.
sgd does not depend data size,also nesterov does not.
it works as long as the data load correctly.

@come2ry
Copy link
Contributor

come2ry commented Sep 1, 2022

@watason
It appears that the test of learning with this optimization function is only guaranteed to work with 5 input data.

Is there a guarantee that this optimization function will not cause errors or accuracy problems with, for example, 1,000,000 data inputs?

@watason
Copy link
Contributor Author

watason commented Sep 1, 2022

@come2ry

Is there a guarantee that this optimization function will not cause errors or accuracy problems with, for example, 1,000,000 data inputs?

i see.
are you asking me to guarantee the input size?
then i think this is not the place to talk about it.
if you want the number of cases of guarantee , please make it an issue in another task.
no other optimizer guarantees it.
basically, it depends on sgd.
if sgd works , it works.

@come2ry
Copy link
Contributor

come2ry commented Sep 1, 2022

Okay, I understand.

Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! LGTM.

This is a quite minute thing, but there is a notational variation in the author of the commit.
Could you correct it if you don't mind?
Also, please register email address used to GitHub for showing icon. 🙇

@watason
Copy link
Contributor Author

watason commented Sep 1, 2022

@arukuka
wtf
asap i change.
thanks!

@watason watason force-pushed the feature/ichikawa/nest branch from 4f81593 to 6d75565 Compare September 1, 2022 04:19
Copy link
Member

@arukuka arukuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick response!
I will merge it.

@arukuka arukuka merged commit 690dc39 into develop Sep 1, 2022
@arukuka arukuka deleted the feature/ichikawa/nest branch September 1, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants