Skip to content
This repository was archived by the owner on Mar 16, 2024. It is now read-only.

Conversation

@g-linville
Copy link
Contributor

@g-linville g-linville commented Apr 17, 2023

Checklist

  • The title of this PR would make a good line in Acorn's Release Note's Changelog
  • The title of this PR ends with a link to the main issue being address in parentheses, like: This is a title (#1216). Here's an example
  • All relevant issues are referenced in the PR description. NOTE: don't use GitHub keywords that auto-close issues
  • Commits follow contributing guidance
  • Automated tests added to cover the changes. If tests couldn't be added, an explanation is provided in the Verification and Testing section
  • Changes to user-facing functionality, API, CLI, and upgrade impacts are clearly called out in PR description
  • PR has at least two approvals before merging (or a reasonable exception, like it's just a docs change)

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville requested a review from thedadams April 17, 2023 23:46
@g-linville g-linville marked this pull request as draft April 17, 2023 23:46
@ibuildthecloud
Copy link
Member

I don't think this makes any difference. AFAIK we are already using the pure go resolver because the binary is not linked to glibc at all (at least on linux). I could be wrong, but if you get

$ ldd bin/acorn 
	not a dynamic executable

I don't see how it could not be using pure go.

@cjellick
Copy link
Member

oh wow. this 100% fixes it for me locally

@cjellick
Copy link
Member

i didnt think you had to mess with -tags netgo anymore

@g-linville
Copy link
Contributor Author

For me, on macOS, I never hit the issue with -tags netgo. I sometimes hit it without that. I agree that it's strange...

Signed-off-by: Grant Linville <grant@acorn.io>
@g-linville g-linville self-assigned this Apr 18, 2023
@g-linville g-linville marked this pull request as ready for review April 18, 2023 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants