Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACSF Multi-Site Deploy Failure #3362

Closed
mikemadison13 opened this issue Feb 5, 2019 · 2 comments
Closed

ACSF Multi-Site Deploy Failure #3362

mikemadison13 opened this issue Feb 5, 2019 · 2 comments
Assignees
@lcatlett @mikemadison13
Labels
Bug Something isn't working

Comments

@mikemadison13
Copy link
Contributor

mikemadison13 commented Feb 5, 2019 •
edited
Loading

My system information:

  • BLT version: 9.2.3

During AFSC Deploy

I get the following output:

Notice: Undefined offset: 3 in /mnt/www/html/<project>/vendor/acquia/blt/scripts/blt/drush/cache.php on line 11
Error: Not enough arguments. Site, environment, and uri are required..

And I expected this to happen:
Deploy to succeed.

This appears related to updates made here #3166 by @lcatlett.

After discussing with her, this may be an issue. If so, we will likely need to port forward to 10.x.

I don't understand why the URI isn't defined here: https://github.com/acquia/blt/blob/9.2.x/scripts/blt/drush/cache.php#L15 which is being called from https://github.com/acquia/blt/blob/9.2.x/scripts/factory-hooks/db-update/db-update.sh#L35

@grasmash this is related to work you were involved in, so we should discuss.
@mikemadison13 mikemadison13 added acsf Bug Something isn't working labels Feb 5, 2019
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 6, 2019
@mikemadison13
Fixes acquia#3362 for 10.x. Attempts to set a fallback if URI is not …
a129ed4 
…identified.
@mikemadison13 mikemadison13 mentioned this issue Feb 6, 2019
Merged
@mikemadison13
Copy link
Contributor Author

I tried a deployment with the patch in my PR. I can confirm that in that case, it did randomize a directory..

I noticed then that there were some additional warnings in the output:

 �[37;46;1m[info]�[39;49;22m Undefined variable: data includes.php:55
 �[37;46;1m[info]�[39;49;22m Undefined offset: 0 includes.php:58
 �[37;46;1m[info]�[39;49;22m Undefined variable: data includes.php:55
 �[37;46;1m[info]�[39;49;22m Undefined offset: 0 includes.php:58

I was concerned my patch caused these, but then I compared with another project. That project was able to set the cache directory WITHOUT my patch (good) but these undefined offset issues were there as well... So I think this is something else. I'm wondering if the issue has to do with #3322 where some of the variables in the includes file (data in particular) is not properly scoped / set for the code to run.

@mikemadison13
Copy link
Contributor Author

mikemadison13 commented Feb 6, 2019 •
edited
Loading

This issue is related to #3372. #3372 is the cause of this, but we should still gracefully. The answer may be to force enable the acsf_module and not randomize the cache string.

We do still need to figure out why the data warnings are happening though.

mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 12, 2019
@mikemadison13
Fixes acquia#3362 to better identify why the site URI is not found.
6f2d314
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 13, 2019
@mikemadison13
Fixes acquia#3362 to better identify why the site URI is not found.
b7fa60b
mikemadison13 added a commit that referenced this issue Feb 13, 2019
@mikemadison13
Fixes #3362 to better identify why the site URI is not found. (#3369)
02932ac
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 21, 2019
@mikemadison13
Fixes acquia#3362 to better identify why the site URI is not found. (a…
c9c7c83 
…cquia#3369)
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 21, 2019
@mikemadison13
Fixes acquia#3362 to better identify why the site URI is not found. (a…
1b11340 
…cquia#3369)
mikemadison13 added a commit that referenced this issue Feb 25, 2019
@mikemadison13
Backport 9.2.x (#3402)
5a05ec4 
* Fixes #3265 to expand alias documentation. (#3399)

* Fixes #3401 for 9.2.x to update devel.

* Moved pipelines-deploy from build event to post-deploy event (#3374)

* Docksal documentation (#3268)

* Add links to docsal and ddev pages.

* Updates ignore-existing to include .editorconfig. (#3300)

Fixes #3169 
--------

Changes proposed:
---------
(What are you proposing we change?)

- adds the .editorconfig file to the ignore list for blt updates

* Updating BLT's docs to remove nvm and point to Cog's documentation for theme installation. (#3313)

* Fix broken link to Cloud Hooks docs. (#3331)

* Added steps to install nfs-utils and enable access via firewalld; without it DrupalVm gets stuck at mounting NFS (#3376)

* Updates release and readme docs. (#3382)

* Updates Travis and Pipelines to PHP 7.1 by default.

* Adds FAQ for drush 8/9 permission denied issue. (#3264)

* Add setup instructions for PHPStorm + PHPUnit (#1787) (#3198)

* Update INSTALL.md (#3273)

* Speed up deploys with shallow fetching (#3271)

Before:
```
real	4m11.340s
user	1m3.430s
sys	1m23.638s
```

After:
```
real	3m14.776s
user	0m47.570s
sys	1m6.415s
```

* Fixes #3217 to provide acsf-init-verify as part of git hooks and blt validate. (#3218)

* Updating Drupal VM config versions. (#3328)

* Fixes #3345 to run db updates even when config strategy is none. (#3363)

* Fixes #3362 to better identify why the site URI is not found. (#3369)

* Test tests:acsf:validate (#3392)

* Test tests:acsf:validate

* Delete README.md

Remove cloud hook readme.

* Update AcsfHooksTest.php

* Update AcsfHooksTest.php

* Update DeployTest.php

* Fixes #3383 to backport Pipelines update to 9.2.x.

* Increase wait timeout. (#3163)

* Fixes #3122 to remove misleading jmeter example. (#3230)

* Fixes #3223 to update git docs. (#3226)
@rmuit rmuit mentioned this issue Feb 28, 2019
Merged
@mikemadison13 mikemadison13 mentioned this issue Feb 28, 2019
Merged
@lcatlett lcatlett mentioned this issue Mar 14, 2019
Closed
@lcatlett lcatlett mentioned this issue Mar 14, 2019
Merged
@mikemadison13 mikemadison13 mentioned this issue May 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcatlett lcatlett

@mikemadison13 mikemadison13

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lcatlett @mikemadison13