Moved pipelines-deploy from build event to post-deploy event #3374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We probably need to emit a message in an update hook to let people know that they’ll need to regenerate their build file. |
|
We also need to back port this to 9.2.x and 9.x as well, as it will impact everyone using pipelines. |
|
#3380 covers regenerating settings files in BLT 10.x, and I added pipelines to that update. |
mikemadison13
pushed a commit
that referenced
this pull request
Feb 21, 2019
mikemadison13
added a commit
that referenced
this pull request
Feb 25, 2019
* Fixes #3265 to expand alias documentation. (#3399) * Fixes #3401 for 9.2.x to update devel. * Moved pipelines-deploy from build event to post-deploy event (#3374) * Docksal documentation (#3268) * Add links to docsal and ddev pages. * Updates ignore-existing to include .editorconfig. (#3300) Fixes #3169 -------- Changes proposed: --------- (What are you proposing we change?) - adds the .editorconfig file to the ignore list for blt updates * Updating BLT's docs to remove nvm and point to Cog's documentation for theme installation. (#3313) * Fix broken link to Cloud Hooks docs. (#3331) * Added steps to install nfs-utils and enable access via firewalld; without it DrupalVm gets stuck at mounting NFS (#3376) * Updates release and readme docs. (#3382) * Updates Travis and Pipelines to PHP 7.1 by default. * Adds FAQ for drush 8/9 permission denied issue. (#3264) * Add setup instructions for PHPStorm + PHPUnit (#1787) (#3198) * Update INSTALL.md (#3273) * Speed up deploys with shallow fetching (#3271) Before: ``` real 4m11.340s user 1m3.430s sys 1m23.638s ``` After: ``` real 3m14.776s user 0m47.570s sys 1m6.415s ``` * Fixes #3217 to provide acsf-init-verify as part of git hooks and blt validate. (#3218) * Updating Drupal VM config versions. (#3328) * Fixes #3345 to run db updates even when config strategy is none. (#3363) * Fixes #3362 to better identify why the site URI is not found. (#3369) * Test tests:acsf:validate (#3392) * Test tests:acsf:validate * Delete README.md Remove cloud hook readme. * Update AcsfHooksTest.php * Update AcsfHooksTest.php * Update DeployTest.php * Fixes #3383 to backport Pipelines update to 9.2.x. * Increase wait timeout. (#3163) * Fixes #3122 to remove misleading jmeter example. (#3230) * Fixes #3223 to update git docs. (#3226)
mikemadison13
pushed a commit
to mikemadison13/blt
that referenced
this pull request
Feb 27, 2019
mikemadison13
added a commit
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
(What are you proposing we change?)
pipelines-deploycommand from thebuildevent into thepost-deployevent.buildevent is used to create the pipelines build branch. At the completion of the build event, the build branch gets pushed to Acquia Git. This means that thepipelines-deploycommand that creates an ODE/CDE and deploys the build branch to it should be called only after thebuildevent, when build branch exists on Acquia Git. Because of reasons I will not detail here, callingpipelines-deployinside thebuildevent was possible and it was working, but this will change in the very near future. In order for the Pipelines yaml files that are generated using BLT to continue to work, the change in this PR is needed.Steps to verify the solution:
(How does someone verify that this does what you think does?)