Fixes #3345 to run db updates even when config strategy is none. #3363
Conversation
There was a problem hiding this comment.
This makes sense to me @mikemadison13, thanks for proposing this!
One thing I was unsure of is around the UUID thing, because I don't really understand what that's doing... but if there's no config export/import, then maybe that is irrelevant.
The only other thing I think that I would be missing here is a cache-rebuild that gets done inside the config-export. Would someone who has no config strategy still benefit from a drush cr? I think yes...? Maybe we run one final one after import AND toggle modules?
|
@dpagini updb runs a cr as part of the process, so i think that covers that. the uuid thing is, a bit of a hack. we were running into issues last year where UUID wasn't matching between existing config and current site config. so BLT force writes the config UUID to match. I think it won't matter for database updates. |
|
Perfect! Thanks so much then, makes sense to me! |
|
there is, of course, an ongoing debate on if a cr should be applied BEFORE the database updates, and i don't want to step into that bear trap in this refactoring. we can fight that out elsewhere. |
* Fixes #3265 to expand alias documentation. (#3399) * Fixes #3401 for 9.2.x to update devel. * Moved pipelines-deploy from build event to post-deploy event (#3374) * Docksal documentation (#3268) * Add links to docsal and ddev pages. * Updates ignore-existing to include .editorconfig. (#3300) Fixes #3169 -------- Changes proposed: --------- (What are you proposing we change?) - adds the .editorconfig file to the ignore list for blt updates * Updating BLT's docs to remove nvm and point to Cog's documentation for theme installation. (#3313) * Fix broken link to Cloud Hooks docs. (#3331) * Added steps to install nfs-utils and enable access via firewalld; without it DrupalVm gets stuck at mounting NFS (#3376) * Updates release and readme docs. (#3382) * Updates Travis and Pipelines to PHP 7.1 by default. * Adds FAQ for drush 8/9 permission denied issue. (#3264) * Add setup instructions for PHPStorm + PHPUnit (#1787) (#3198) * Update INSTALL.md (#3273) * Speed up deploys with shallow fetching (#3271) Before: ``` real 4m11.340s user 1m3.430s sys 1m23.638s ``` After: ``` real 3m14.776s user 0m47.570s sys 1m6.415s ``` * Fixes #3217 to provide acsf-init-verify as part of git hooks and blt validate. (#3218) * Updating Drupal VM config versions. (#3328) * Fixes #3345 to run db updates even when config strategy is none. (#3363) * Fixes #3362 to better identify why the site URI is not found. (#3369) * Test tests:acsf:validate (#3392) * Test tests:acsf:validate * Delete README.md Remove cloud hook readme. * Update AcsfHooksTest.php * Update AcsfHooksTest.php * Update DeployTest.php * Fixes #3383 to backport Pipelines update to 9.2.x. * Increase wait timeout. (#3163) * Fixes #3122 to remove misleading jmeter example. (#3230) * Fixes #3223 to update git docs. (#3226)
Fixes #3345
Changes proposed:
(What are you proposing we change?)
Steps to verify the solution:
(How does someone verify that this does what you think does?)