Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate ACSF Settings during BLT Validate #3217

Closed
mikemadison13 opened this issue Nov 6, 2018 · 0 comments
Closed

Validate ACSF Settings during BLT Validate #3217

mikemadison13 opened this issue Nov 6, 2018 · 0 comments
Assignees
@mikemadison13
Labels
Enhancement A feature or feature request

Comments

@mikemadison13
Copy link
Contributor

mikemadison13 commented Nov 6, 2018 •
edited

Proposed Changes:

  • Add a new tests:acsf:validate command that runs the acsf-init-validate command to be run during blt:validate process. This will ensure that builds fail when the acsf-init command needs to be run, hopefully preventing failed deployments

Note that I propose we add a new config key to prevent this from running on all sites by default. ACSF sites that wish to have this run automatically would need to update blt.yml to include:

  • validate:
    -- acsf: true
@mikemadison13 mikemadison13 added Enhancement A feature or feature request 10.0.x labels Nov 6, 2018
@mikemadison13 mikemadison13 self-assigned this Nov 6, 2018
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 6, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
67617f9 
…d blt validate.
@mikemadison13 mikemadison13 mentioned this issue Nov 6, 2018
Merged
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 6, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
bbf9c2b 
…d blt validate.
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 6, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
71dbf4f 
…d blt validate.
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 6, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
7534f07 
…d blt validate.
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 8, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
221b22a 
…d blt validate.
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Nov 8, 2018
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
3866e31 
…d blt validate.
@mikemadison13 mikemadison13 mentioned this issue Nov 9, 2018
Closed
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Jan 3, 2019
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
7836076 
…d blt validate.
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Jan 3, 2019
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
c170143 
…d blt validate.
mikemadison13 added a commit that referenced this issue Jan 4, 2019
@mikemadison13
Fixes #3217 to provide acsf-init-verify as part of git hooks and blt …
5ce159b 
…validate. (#3218)
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 21, 2019
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
6493e80 
…d blt validate. (acquia#3218)
mikemadison13 added a commit to mikemadison13/blt that referenced this issue Feb 21, 2019
@mikemadison13
Fixes acquia#3217 to provide acsf-init-verify as part of git hooks an…
1e0f84c 
…d blt validate. (acquia#3218)
mikemadison13 added a commit that referenced this issue Feb 25, 2019
@mikemadison13
Backport 9.2.x (#3402)
5a05ec4 
* Fixes #3265 to expand alias documentation. (#3399)

* Fixes #3401 for 9.2.x to update devel.

* Moved pipelines-deploy from build event to post-deploy event (#3374)

* Docksal documentation (#3268)

* Add links to docsal and ddev pages.

* Updates ignore-existing to include .editorconfig. (#3300)

Fixes #3169 
--------

Changes proposed:
---------
(What are you proposing we change?)

- adds the .editorconfig file to the ignore list for blt updates

* Updating BLT's docs to remove nvm and point to Cog's documentation for theme installation. (#3313)

* Fix broken link to Cloud Hooks docs. (#3331)

* Added steps to install nfs-utils and enable access via firewalld; without it DrupalVm gets stuck at mounting NFS (#3376)

* Updates release and readme docs. (#3382)

* Updates Travis and Pipelines to PHP 7.1 by default.

* Adds FAQ for drush 8/9 permission denied issue. (#3264)

* Add setup instructions for PHPStorm + PHPUnit (#1787) (#3198)

* Update INSTALL.md (#3273)

* Speed up deploys with shallow fetching (#3271)

Before:
```
real	4m11.340s
user	1m3.430s
sys	1m23.638s
```

After:
```
real	3m14.776s
user	0m47.570s
sys	1m6.415s
```

* Fixes #3217 to provide acsf-init-verify as part of git hooks and blt validate. (#3218)

* Updating Drupal VM config versions. (#3328)

* Fixes #3345 to run db updates even when config strategy is none. (#3363)

* Fixes #3362 to better identify why the site URI is not found. (#3369)

* Test tests:acsf:validate (#3392)

* Test tests:acsf:validate

* Delete README.md

Remove cloud hook readme.

* Update AcsfHooksTest.php

* Update AcsfHooksTest.php

* Update DeployTest.php

* Fixes #3383 to backport Pipelines update to 9.2.x.

* Increase wait timeout. (#3163)

* Fixes #3122 to remove misleading jmeter example. (#3230)

* Fixes #3223 to update git docs. (#3226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikemadison13 mikemadison13

Labels
Enhancement A feature or feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mikemadison13