Skip to content

CLI-1461: De-alias thecodingmachine/safe#1969

Merged
danepowell merged 1 commit intoacquia:mainfrom
danepowell:CLI-1461
Feb 25, 2026
Merged

CLI-1461: De-alias thecodingmachine/safe#1969
danepowell merged 1 commit intoacquia:mainfrom
danepowell:CLI-1461

Conversation

@danepowell
Copy link
Contributor

Motivation

Fixes CLI-1461

Proposed changes

Alternatives considered

Testing steps

  1. Follow the contribution guide to set up your development environment or download a pre-built acli.phar for this PR.
  2. If running from source, clear the kernel cache to pick up new and changed commands: ./bin/acli ckc
  3. Check for regressions: (add specific steps for this pr)
  4. Check new functionality: (add specific steps for this pr)

Copilot AI review requested due to automatic review settings February 25, 2026 00:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the version alias for the thecodingmachine/safe package, changing from "3.0.2 as 2.5.0" to "3.0.2". This de-aliasing is appropriate because dependencies like infection/infection now require ^v3.0, making the compatibility alias to v2.5.0 unnecessary. The PR also includes routine dependency updates as part of running composer update.

Changes:

  • Removed version alias for thecodingmachine/safe package in composer.json
  • Updated composer.lock to reflect the de-aliasing and include latest compatible dependency versions
  • Removed the alias entry from the composer.lock aliases section

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
composer.json Removed version alias "3.0.2 as 2.5.0" and changed to "3.0.2" for thecodingmachine/safe
composer.lock Updated lock file with de-aliased version, removed alias entry, and included routine dependency updates (Symfony components, dev tools, etc.)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Try the dev build for this PR: https://acquia-cli.s3.amazonaws.com/build/pr/1969/acli.phar

curl -OL https://acquia-cli.s3.amazonaws.com/build/pr/1969/acli.phar
chmod +x acli.phar

@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.30%. Comparing base (21f14b4) to head (b0a85b2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1969   +/-   ##
=========================================
  Coverage     92.30%   92.30%           
  Complexity     1921     1921           
=========================================
  Files           122      122           
  Lines          7009     7009           
=========================================
  Hits           6470     6470           
  Misses          539      539           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@danepowell danepowell merged commit 3103257 into acquia:main Feb 25, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants