Fixes #370: acli push:files creates an extra "files" directory.

[grasmash]

No description provided.

[grasmash]

This is failing for reasons unrelated to the changes. The Windows build is defaulting to PHP 8.0.0, and the PHP 7.4 build is passing tests but failing to execute coveralls.

[anavarre]

FYI you're not working from a branch but from master.

[anavarre]

Not sure if it's me or the PR but I'm running into an issue when trying to test this PR

$ /tmp/cli/bin/acli push:files -vvv
Acquia CLI version: @package_version@

In AbstractProvider.php line 539:
                                                                       
  [UnexpectedValueException]                                           
  Invalid response received from Authorization Server. Expected JSON.  
                                                                       

Exception trace:
  at /tmp/cli/vendor/league/oauth2-client/src/Provider/AbstractProvider.php:539
 League\OAuth2\Client\Provider\AbstractProvider->getAccessToken() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Connector/Connector.php:74
 AcquiaCloudApi\Connector\Connector->AcquiaCloudApi\Connector\{closure}() at /tmp/cli/vendor/symfony/cache/LockRegistry.php:99
 Symfony\Component\Cache\LockRegistry::compute() at /tmp/cli/vendor/symfony/cache/Traits/ContractsTrait.php:88
 Symfony\Component\Cache\Adapter\AbstractAdapter->Symfony\Component\Cache\Traits\{closure}() at /tmp/cli/vendor/symfony/cache-contracts/CacheTrait.php:70
 Symfony\Component\Cache\Adapter\AbstractAdapter->doGet() at /tmp/cli/vendor/symfony/cache/Traits/ContractsTrait.php:95
 Symfony\Component\Cache\Adapter\AbstractAdapter->doGet() at /tmp/cli/vendor/symfony/cache-contracts/CacheTrait.php:33
 Symfony\Component\Cache\Adapter\AbstractAdapter->get() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Connector/Connector.php:75
 AcquiaCloudApi\Connector\Connector->createRequest() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Connector/Connector.php:92
 AcquiaCloudApi\Connector\Connector->sendRequest() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Connector/Client.php:128
 AcquiaCloudApi\Connector\Client->makeRequest() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Connector/Client.php:117
 AcquiaCloudApi\Connector\Client->request() at /tmp/cli/vendor/typhonius/acquia-php-sdk-v2/src/Endpoints/Applications.php:40
 AcquiaCloudApi\Endpoints\Applications->get() at /tmp/cli/src/Command/CommandBase.php:874
 Acquia\Cli\Command\CommandBase->getCloudApplication() at /tmp/cli/src/Command/CommandBase.php:695
 Acquia\Cli\Command\CommandBase->determineCloudApplication() at /tmp/cli/src/Command/Pull/PullCommandBase.php:571
 Acquia\Cli\Command\Pull\PullCommandBase->determineEnvironment() at /tmp/cli/src/Command/Push/PushFilesCommand.php:45
 Acquia\Cli\Command\Push\PushFilesCommand->execute() at /tmp/cli/vendor/symfony/console/Command/Command.php:258
 Symfony\Component\Console\Command\Command->run() at /tmp/cli/src/Command/CommandBase.php:354
 Acquia\Cli\Command\CommandBase->run() at /tmp/cli/vendor/symfony/console/Application.php:938
 Symfony\Component\Console\Application->doRunCommand() at /tmp/cli/vendor/symfony/console/Application.php:266
 Symfony\Component\Console\Application->doRun() at /tmp/cli/vendor/symfony/console/Application.php:142
 Symfony\Component\Console\Application->run() at /tmp/cli/bin/acli:89

push:files [-h|--help] [-q|--quiet] [-v|vv|vvv|--verbose] [-V|--version] [--ansi] [--no-ansi] [-n|--no-interaction] [--] <command> [<dir> [<environmentId>]]

I did run the ckc command and ran composer install. Anything I missed?

[grasmash]

FYI you're not working from a branch but from master.

Not sure what you mean... this is from the issue-370-files-dir branch.

[anavarre]

Sorry, meant that you're not working from your fork.

[grasmash]

touch docroot/sites/default/files/testing-371
./bin/acli push:files -vvv
acli ssh [site.env] -- ls -lash docroot/sites/default/files/ | grep 371

Seems to work for me. :)

[grasmash]

Sorry, meant that you're not working from your fork.

Yeah my fork is messed up.