Fix comment bot panic when !check is used with hostname-only address#198
Closed
Fix comment bot panic when !check is used with hostname-only address#198
!check is used with hostname-only address#198Conversation
Closed
…check comment Agent-Logs-Url: https://github.com/acresources/serverslist/sessions/025bf5fd-c574-4813-84d5-f8eec438de40 Co-authored-by: amoeba <563+amoeba@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix parsing issue in comment check bot
Fix comment bot panic when Apr 1, 2026
!check is used with hostname-only address
Collaborator
|
(Just testing copilot on this since I haven't done it much) |
Collaborator
|
!check the-tower.ddns.net |
|
⏳ Checking if I can connect and log in to the-tower.ddns.net. Give me a minute... |
|
✅ the-tower.ddns.net was up and I was able to log in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ac-server-monitorrequireshost:portformat for-check, but the comment bot was passing only the hostname (e.g.,play.coldeve.ac), causing a panic and exit code 2.Changes
actions/checkout@v4before the extract step soServers.xmlis availableServers.xml— when the provided address has no:, Python parsesServers.xmlto look up the matchingserver_port; falls back to the bare hostname if not foundhost:portinput — if the comment already includes a port, it's used as-is