SK-298 // chore: minor style updates - #262
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #262 +/- ##
=======================================
Coverage 79.20% 79.20%
=======================================
Files 61 61
Lines 4010 4010
=======================================
Hits 3176 3176
Misses 834 834 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ogorman89
force-pushed
the
ian/minor-cleanup
branch
from
July 14, 2026 16:46
0848b02 to
533a3d8
Compare
ogorman89
commented
Jul 14, 2026
| use sk_api::v1::{ | ||
| Simulation, | ||
| SimulationRoot, | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
because we are no longer importing prelude in sk-core/src/k8s/mod.rs
ogorman89
commented
Jul 14, 2026
| use sk_testutils::*; | ||
|
|
||
| use super::*; | ||
| use crate::constants::*; |
Contributor
Author
There was a problem hiding this comment.
also now needed because the prelude is not being imported in sk-core/src/k8s/mod.rs
ogorman89
commented
Jul 14, 2026
| @@ -1,5 +1,6 @@ | |||
| use assertables::*; | |||
| use clockabilly::Utc; | |||
| use kube::api::DynamicObject; | |||
Contributor
Author
There was a problem hiding this comment.
and .... also now needed because the prelude is not being imported in sk-core/src/k8s/mod.rs
drmorr0
approved these changes
Jul 14, 2026
Comment on lines
+18
to
+21
| DEPL_REVISION_LABEL_KEY, | ||
| GVK, | ||
| KubernetesError, | ||
| LAST_APPLIED_CONFIG_LABEL_KEY, |
Contributor
There was a problem hiding this comment.
Feel like these should be moved into constants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description and Rationale
use crate::prelude::*; prefer explicit imports for clarityuse crate::constants::*; constants should all have descriptive names and are co-located so explicit imports don't offer the same clarity benefit that importing functionality doesThese are all quite minor.
Test Steps
make test[ X ] I certify that this PR does not contain any code that has been generated with GitHub Copilot or any other AI-based code generation tool, in accordance with this project's policies.