Skip to content

Conversation

@chrismaree
Copy link
Member

In HubPool.sol:
line 99: "Heler" should be "Helper"
line 201: "proposal" should be "Proposal"
line 235: "its" should be "it's"
line 294: "disputes.." should be "disputes."
line 377: "for again" should be "again."
line 419: "access more funds that" should be "to access more funds than"
line 475: "to along" should be "along"
line 480: "leafs" should be "leaves"
line 532: "neccessary" should be "necessary"
line 568: "to back" should be "back"
line 569: "leafs" should be "leaves"
line 569: "wont" should be "won't"
line 865: "timeFromLastInteraction ,undistributedLpFees)" should be "timeFromLastInteraction,
undistributedLpFees)"
line 866: "a fees." should be "fees."
line 913: "decrease" should be "decreased"
line 962: "send" should be "sent"
In HubPoolInterface.sol:
line 13: "sent" should be "send"
In MerkleLib.sol:
line 86: "*" should be "*"
In Polygon_SpokePool.sol:
line 43: "priviledges" should be "privileges"
In SpokePool.sol:
line 55: "token" should be "chain"
line 67: "leafs" should be "leaves"
line 292: "users" should be "user's"
line 347: "receipient." should be "recipient."
In SpokePoolInterface.sol:
line 11: "inverted." should be "negated."
line 27: "a the" should be "the"

Signed-off-by: chrismaree <christopher.maree@gmail.com>
@chrismaree
Copy link
Member Author

Another change I made was to replace all instances of leafs with leaves through the repo.

@chrismaree chrismaree added the OZ Audit - March Resolves issue discovered in March 2022 OZ Audit label Mar 16, 2022
@mrice32 mrice32 self-requested a review March 17, 2022 12:27
Copy link
Contributor

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed:

  • HubPool: line 294: "disputes.." should be "disputes."

struct RelayerRefundLeaf {
// This is the amount to return to the HubPool. This occurs when there is a PoolRebalanceLeaf netSendAmount that is
// negative. This is just that value inverted.
// negative. This is just the negative of this value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this change is consistent with #102 !

Copy link
Member

@nicholaspai nicholaspai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one tiny nit

Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Signed-off-by: chrismaree <christopher.maree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OZ Audit - March Resolves issue discovered in March 2022 OZ Audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants