chrismaree/add block number to export #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
commented
Apr 20, 2022
| "PolygonTokenBridger": "0xF92B101f07df74B1f4f3160f9e8a25D48BA5d583", | ||
| "Polygon_Adapter": "0xd8176EBf6170513Aa232D065042fa480557232A4", | ||
| "RateModelStore": "0x18a200A2427e243154EC8217890Bc08062afc5A2" | ||
| "Arbitrum_Adapter": { "address": "0x18F4D98C7CeA6Ab934F2976c2a98009A529d8F49", "blockNumber": 10367195 }, |
Member
Author
There was a problem hiding this comment.
notice this! we now have exported address and block number for all contracts on all chains :)
chrismaree
commented
Apr 20, 2022
| } | ||
|
|
||
| // Returns the deployment block number of any contract on any network. | ||
| export function getDeployedBlockNumber(contractName: string, networkId: number): string { |
Member
Author
There was a problem hiding this comment.
the bots can use this method to see where to query from.
nicholaspai
approved these changes
Apr 21, 2022
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
Does this introduce breaking changes to relayer-v2?
Member
Author
nope! latest code there requires these changes. |
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional exports to our deployments file. they now contain the block number at which each contract on each network is exported. this is used by the relayer to decrease how many blocks lookback we need when initializing clients to decrease node burden.