fix[N13] Add more approval requirement comments #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
added
the
OZ Audit - March
nicholaspai
reviewed
Mar 17, 2022
nicholaspai
reviewed
Mar 17, 2022
nicholaspai
reviewed
Mar 17, 2022
nicholaspai
reviewed
Mar 17, 2022
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Co-authored-by: nicholaspai <9457025+nicholaspai@users.noreply.github.com>
Merge branch 'master' into chrismaree/n13
…art-contracts-v2 into chrismaree/n13
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Throughout the codebase, when the safeTransferFrom function is used to transfer assets into the
system from an external address there is an implicit requirement that the external address has already
granted the appropriate approvals.
For instance:
been granted an allowance of bondAmount bondTokens by the caller.
granted an l1TokenAmount allowance of the caller's l1Token.
Solution:
This PR addresses this issue by adding additional comments.