fix: [L02] prevent locking in the case of misparameterization #142
Conversation
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
|
Can you explain the failure case this addresses? |
@nicholaspai great point. Added a description that describes this. PTAL. |
contracts/PolygonTokenBridger.sol
Outdated
| if (isWrappedMatic) { | ||
| uint256 balance = address(this).balance; | ||
| maticToken.withdraw{ value: balance }(balance); | ||
| } |
There was a problem hiding this comment.
nit: does this need to be a separate state variable? could it not be:
| if (isWrappedMatic) { | |
| uint256 balance = address(this).balance; | |
| maticToken.withdraw{ value: balance }(balance); | |
| } | |
| if (isWrappedMatic) maticToken.withdraw{ value: address(this).balance }(balance); |
There was a problem hiding this comment.
seems reasonable and saves an MSTORE right?
There was a problem hiding this comment.
I don't think the above works, since balance doesn't exist. Maybe you meant:
if (isWrappedMatic) maticToken.withdraw{ value: address(this).balance }(address(this).balance);
?
We could do that. I'm not sure it would be cheaper, but that might not matter since this is on polygon and the call is already pretty cheap.
There was a problem hiding this comment.
ye, sorry. it's hard to structure feedback in these comments with the proposed blocks. what you did is what I had intended.
Signed-off-by: Matt Rice <matthewcrice32@gmail.com>
mrice32
added
the
OZ Audit - March
This addresses two potential cases where tokens get locked:
In both cases, this ensures that the tokens make it to the HubPool contract.