feat: Change RateModelStore => ConfigStore and add fields #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrice32
approved these changes
May 3, 2022
Contributor
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Looks great! Only one minor comment
contracts/TokenConfigStore.sol
Outdated
Comment on lines
24
to
45
| event UpdatedRateModel(address indexed l1Token, string rateModel); | ||
| event UpdatedTransferThreshold(address indexed l1Token, uint256 transferThreshold); | ||
|
|
||
| /** | ||
| * @notice Updates rate model string for L1 token. | ||
| * @param l1Token the l1 token rate model to update. | ||
| * @param rateModel the updated rate model. | ||
| */ | ||
| function updateRateModel(address l1Token, string memory rateModel) external onlyOwner { | ||
| l1TokenRateModels[l1Token] = rateModel; | ||
| emit UpdatedRateModel(l1Token, rateModel); | ||
| } | ||
|
|
||
| /** | ||
| * @notice Updates token transfer threshold percentage for L1 token. | ||
| * @param l1Token the l1 token rate model to update. | ||
| * @param transferThresholdPct the updated transfer threshold percentage. | ||
| */ | ||
| function updateTransferThreshold(address l1Token, uint256 transferThresholdPct) external onlyOwner { | ||
| l1TokenTransferThresholds[l1Token] = transferThresholdPct; | ||
| emit UpdatedTransferThreshold(l1Token, transferThresholdPct); | ||
| } |
Contributor
There was a problem hiding this comment.
Why not just have a single config string to contain the rate model fields and the transfer threshold? That way we can add more token specific config later if needed?
chrismaree
approved these changes
May 4, 2022
This was referenced May 6, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds constants from UMIP to
ConfigStorecontract.