Skip to content

fix(optimism-adapter): handle custom bridges #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2022
Merged

fix(optimism-adapter): handle custom bridges #68

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac12bae
fix for optimism
chrismaree Mar 3, 2022
e6ef507
nit
chrismaree Mar 3, 2022
136be99
nit
chrismaree Mar 3, 2022
c33f72f
nit
chrismaree Mar 4, 2022
acbb6ba
nit
chrismaree Mar 7, 2022
0744e6c
nit
chrismaree Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions contracts/chain-adapters/Optimism_Adapter.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,16 @@ contract Optimism_Adapter is CrossDomainEnabled, AdapterInterface {

IL1StandardBridge public immutable l1StandardBridge;

// Optimism has the ability to support "custom" bridges. These bridges are not supported by the canonical bridge
// and so we need to store the address of the custom token and the associated bridge. In the event we want to
// support a new token that is not supported by Optimism, we can add a new custom bridge for it and re-deploy the
// adapter. A full list of custom optimism tokens and their associated bridges can be found here:
// https://github.com/ethereum-optimism/ethereum-optimism.github.io/blob/master/optimism.tokenlist.json
address public immutable dai = 0x6B175474E89094C44Da98b954EedeAC495271d0F;
address public immutable daiOptimismBridge = 0x10E6593CDda8c58a1d0f14C5164B376352a55f2F;
address public immutable snx = 0xC011a73ee8576Fb46F5E1c5751cA3B9Fe0af2a6F;
address public immutable snxOptimismBridge = 0xCd9D4988C0AE61887B075bA77f08cbFAd2b65068;

event L2GasLimitSet(uint32 newGasLimit);

/**
Expand Down Expand Up @@ -72,8 +82,14 @@ contract Optimism_Adapter is CrossDomainEnabled, AdapterInterface {
l1Weth.withdraw(amount);
l1StandardBridge.depositETHTo{ value: amount }(to, l2GasLimit, "");
} else {
IERC20(l1Token).safeIncreaseAllowance(address(l1StandardBridge), amount);
l1StandardBridge.depositERC20To(l1Token, l2Token, to, amount, l2GasLimit, "");
IL1StandardBridge _l1StandardBridge = l1StandardBridge;

// Check if the L1 token requires a custom bridge. If so, use that bridge over the standard bridge.
Copy link
Member

@nicholaspai nicholaspai Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit is I think it'd be helpful to link to some source where we can look up custom bridges per L1 token. otherwise LGMT

if (l1Token == dai) _l1StandardBridge = IL1StandardBridge(daiOptimismBridge); // 1. DAI
if (l1Token == snx) _l1StandardBridge = IL1StandardBridge(snxOptimismBridge); // 2. SNX

IERC20(l1Token).safeIncreaseAllowance(address(_l1StandardBridge), amount);
_l1StandardBridge.depositERC20To(l1Token, l2Token, to, amount, l2GasLimit, "");
}
emit TokensRelayed(l1Token, l2Token, amount, to);
}
Expand Down