fix(optimism-adapter): handle custom bridges #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaspai
approved these changes
Mar 4, 2022
| l1StandardBridge.depositERC20To(l1Token, l2Token, to, amount, l2GasLimit, ""); | ||
| IL1StandardBridge _l1StandardBridge = l1StandardBridge; | ||
|
|
||
| // Check if the L1 token requires a custom bridge. If so, use that bridge over the standard bridge. |
Member
There was a problem hiding this comment.
Only nit is I think it'd be helpful to link to some source where we can look up custom bridges per L1 token. otherwise LGMT
nicholaspai
changed the title
mrice32
approved these changes
Mar 4, 2022
Comment on lines
82
to
86
| if (l1Token == 0x6B175474E89094C44Da98b954EedeAC495271d0F) | ||
| _l1StandardBridge = IL1StandardBridge(0x10E6593CDda8c58a1d0f14C5164B376352a55f2F); | ||
| // 2. SNX | ||
| if (l1Token == 0xC011a73ee8576Fb46F5E1c5751cA3B9Fe0af2a6F) | ||
| _l1StandardBridge = IL1StandardBridge(0xCd9D4988C0AE61887B075bA77f08cbFAd2b65068); |
Contributor
There was a problem hiding this comment.
Have you thought about naming these?
Like:
address public immutable dai = 0x6B175474E89094C44Da98b954EedeAC495271d0F;
address public immutable daiBridge = 0x10E6593CDda8c58a1d0f14C5164B376352a55f2F;
...
This was referenced Mar 9, 2022
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fully support optimism we need some additional branching logic to change out the bridge address when bridging tokens that require custom bridges. To start with, this includes DAI and SNX.