Skip to content

Fix typos in two examples#2057

Merged
WilcoFiers merged 3 commits intodevelopfrom
fix-typos
May 11, 2023
Merged

Fix typos in two examples#2057
WilcoFiers merged 3 commits intodevelopfrom
fix-typos

Conversation

@WilcoFiers
Copy link
Copy Markdown
Member

Closes w3c/wcag-act-rules#197

Need for Call for Review: none - these should not impact implementation


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@@ -225,7 +225,7 @@ This `section` element with an [explicit role][] of `doc-abstract` has a role fr
There is no element whose role has [required context role][] because the `header` role does not have one.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no element whose role has [required context role][] because the header role does not have one.

"Header" should be amended here too?

Comment thread _rules/aria-required-context-role-ff89c9.md Outdated
@WilcoFiers WilcoFiers requested a review from HelenBurge May 11, 2023 11:52
@WilcoFiers WilcoFiers dismissed HelenBurge’s stale review May 11, 2023 11:53

Good catch. Updated

@WilcoFiers WilcoFiers merged commit 8a5d415 into develop May 11, 2023
@WilcoFiers WilcoFiers deleted the fix-typos branch May 11, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typos in 2 tests

5 participants