Revert "Fix typo and rename status to phase"#4505
Merged
nikola-jokic merged 1 commit intoMay 22, 2026
Merged
Conversation
This reverts commit 8eb6cbe.
nikola-jokic
requested review from
Steve-Glass,
mumoshu,
rentziass and
toast-gear
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
rentziass
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts a prior change (#4466) by adjusting CRD additionalPrinterColumns (and matching kubebuilder printcolumn markers) for several Actions CRDs.
Changes:
- Removes the
Phaseprinter column fromEphemeralRunnerSetCRDs. - Renames the
EphemeralRunner.status.phaseprinter column header fromPhasetoStatus. - Changes the
AutoscalingRunnerSetprinter column JSONPath from.status.phaseto.status.stateand header toState.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| config/crd/bases/actions.github.com_ephemeralrunnersets.yaml | Removes Phase additionalPrinterColumn from EphemeralRunnerSet CRD base. |
| config/crd/bases/actions.github.com_ephemeralrunners.yaml | Renames .status.phase column header from Phase to Status in EphemeralRunner CRD base. |
| config/crd/bases/actions.github.com_autoscalingrunnersets.yaml | Changes AutoscalingRunnerSet printer column JSONPath to .status.state and header to State (currently inconsistent with schema). |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunnersets.yaml | Mirrors EphemeralRunnerSet Phase column removal in Helm chart CRD. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_ephemeralrunners.yaml | Mirrors EphemeralRunner column header rename (Phase -> Status) in Helm chart CRD. |
| charts/gha-runner-scale-set-controller/crds/actions.github.com_autoscalingrunnersets.yaml | Mirrors AutoscalingRunnerSet printer column change to .status.state in Helm chart CRD. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunnersets.yaml | Mirrors EphemeralRunnerSet Phase column removal in experimental Helm chart CRD. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_ephemeralrunners.yaml | Mirrors EphemeralRunner column header rename (Phase -> Status) in experimental Helm chart CRD. |
| charts/gha-runner-scale-set-controller-experimental/crds/actions.github.com_autoscalingrunnersets.yaml | Mirrors AutoscalingRunnerSet printer column change to .status.state in experimental Helm chart CRD. |
| apis/actions.github.com/v1alpha1/ephemeralrunnerset_types.go | Removes kubebuilder printcolumn for .status.phase on EphemeralRunnerSet. |
| apis/actions.github.com/v1alpha1/ephemeralrunner_types.go | Renames kubebuilder .status.phase print column header from Phase to Status. |
| apis/actions.github.com/v1alpha1/autoscalingrunnerset_types.go | Changes kubebuilder printer column JSONPath to .status.state and header to State (currently inconsistent with status struct). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // +kubebuilder:printcolumn:JSONPath=".spec.maxRunners",name=Maximum Runners,type=integer | ||
| // +kubebuilder:printcolumn:JSONPath=".status.currentRunners",name=Current Runners,type=integer | ||
| // +kubebuilder:printcolumn:JSONPath=".status.phase",name=Phase,type=string | ||
| // +kubebuilder:printcolumn:JSONPath=".status.state",name=State,type=string |
Comment on lines
24
to
29
| - jsonPath: .status.currentRunners | ||
| name: Current Runners | ||
| type: integer | ||
| - jsonPath: .status.phase | ||
| name: Phase | ||
| - jsonPath: .status.state | ||
| name: State | ||
| type: string |
Comment on lines
24
to
29
| - jsonPath: .status.currentRunners | ||
| name: Current Runners | ||
| type: integer | ||
| - jsonPath: .status.phase | ||
| name: Phase | ||
| - jsonPath: .status.state | ||
| name: State | ||
| type: string |
Comment on lines
24
to
29
| - jsonPath: .status.currentRunners | ||
| name: Current Runners | ||
| type: integer | ||
| - jsonPath: .status.phase | ||
| name: Phase | ||
| - jsonPath: .status.state | ||
| name: State | ||
| type: string |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4466