do not cap migrated setting retry is exception is session conflict#4557
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the broker-based listener’s session creation and message-polling error handling, aiming to improve resiliency around session creation and expired-session recovery.
Changes:
- Removes the migrated-settings-specific retry limit during session creation.
- Adds a recovery path for
TaskAgentSessionExpiredExceptioninGetNextMessageAsync, gated bySkipSessionRecover.
Show a summary per file
| File | Description |
|---|---|
| src/Runner.Listener/BrokerMessageListener.cs | Adjusts session creation retry behavior and adds session-expired recovery logic during message polling. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Low
Refactor comments for clarity regarding retry limits on migrated settings.
Remove session recovery logic for expired sessions.
aiqiaoy
changed the title
yaananth
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.